Add behavior e2e tests #5146
Merged
Add behavior e2e tests #5146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to expand on this more in the future, e.g. load site up in headless chrome/JSDom and add output matching.
For now, this makes sure our babel runtime work-around works.
Follow up to #5142.
Example failure before addition of #5142:
https://travis-ci.org/Timer/create-react-app/builds/434316343#L1577-L1606
I'd add this to AppVeyor, but I'm thinking we should switch to Azure Pipelines and wait until then.