Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run behavioral smoke tests with Jest, add output tests #5150

Merged
merged 12 commits into from
Sep 28, 2018
Merged

Run behavioral smoke tests with Jest, add output tests #5150

merged 12 commits into from
Sep 28, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 28, 2018 •
edited
Loading

This PR runs behavioral tests via Jest, follow up to #5146.

updates Smoke tests:

  1. smoke test SCSS support with Bootstrap
  2. smoke test @babel/runtime support across major versions, within application and dependencies

adds (true) Output tests:

  1. babel syntax error
  2. css syntax error / broken
  3. missing export / erratic behavior
  4. module not found / suboptimal
  5. eslint warning
  6. eslint error

@Timer Timer added this to the 2.0.0 milestone Sep 28, 2018
@Timer Timer requested a review from gaearon September 28, 2018 08:35
gaearon
gaearon reviewed Sep 28, 2018
View reviewed changes
fixtures/output/webpack-message-formatting/index.test.js
if (sizeIndex !== -1) {
response.stdout = response.stdout.substring(0, sizeIndex);
}
expect(response).toMatchSnapshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this is so great. 😍😍😍

@Timer Timer changed the title Run behavioral smoke tests with Jest Run behavioral smoke tests with Jest, add output tests Sep 28, 2018
@Timer Timer merged commit 2a7346e into facebook:master Sep 28, 2018
@Timer
Copy link
Contributor Author

Timer commented Sep 28, 2018

Givin' myself the enhancement label on this one, too.

@Timer Timer deleted the better-testing branch September 28, 2018 10:19
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement tag: internal
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot