Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removal of newlines from html in docs #6386

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Revert removal of newlines from html in docs #6386

merged 1 commit into from
Mar 9, 2019

Conversation

JBallin
Copy link
Contributor

@JBallin JBallin commented Feb 10, 2019 •
edited
Loading

An unintended change was merged in #6062

@JBallin JBallin changed the title [docs] revert removal of newlines from html in #6062 [docs] revert removal of newlines from html Feb 10, 2019
@JBallin JBallin mentioned this pull request Feb 10, 2019
Merged
@ianschmitz
Copy link
Contributor

I'm not seeing the changed files here on GitHub. Can you clarify what snuck through?

@ianschmitz ianschmitz added this to the 2.1.4 milestone Feb 10, 2019
@JBallin
Copy link
Contributor Author

JBallin commented Feb 10, 2019 •
edited
Loading

@ianschmitz it seems to be something that husky is doing automatically, and unfortunately I'm unable to override it. The form tag is being converted to one line (lines 48-50 in original):
https://github.com/facebook/create-react-app/pull/6062/files#diff-167d7aa95e8f35443e07dd102611e442L48

Is this expected behavior? Feel free to close if so.

@ianschmitz
Copy link
Contributor

Ah yes you mean prettier. I wasn't aware they format code blocks inside of markdown files: https://twitter.com/bohdan_kh/status/1012367393656483841.

You should be able to get prettier to ignore that code block and restore the formatting to how it was previously: https://prettier.io/docs/en/ignore.html#range-ignore

@ianschmitz
Copy link
Contributor

Do you mind using the range ignore instead to just cover the code block?

@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
@JBallin
Copy link
Contributor Author

JBallin commented Feb 15, 2019

@ianschmitz, should be ready now (FYI). Cheers.

@ianschmitz
Copy link
Contributor

Hmm, i'm not sure why but something looks off in the docs in this PR:
https://deploy-preview-6386--create-react-app.netlify.com/create-react-app/docs/adding-custom-environment-variables

You'll see the section that was edited here looks broken compared to master:
https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables

@JBallin
Copy link
Contributor Author

JBallin commented Feb 27, 2019 •
edited
Loading

Fixed by adding spaces above and below code block!
https://deploy-preview-6386--create-react-app.netlify.com/create-react-app/docs/adding-custom-environment-variables

@iansu iansu modified the milestones: 2.1.6, 2.1.x Mar 6, 2019
@ianschmitz ianschmitz modified the milestones: 2.1.x, 2.1.9 Mar 9, 2019
@ianschmitz ianschmitz merged commit 6a034ba into facebook:master Mar 9, 2019
@JBallin JBallin deleted the docs-env-html branch March 9, 2019 23:07
@iansu iansu modified the milestones: 2.1.9, 3.0 Mar 10, 2019
JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019
@JoviDeCroock
Merge branch 'masterd' into feat/modern-build
231a136 
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js
@lock lock bot locked and limited conversation to collaborators Mar 15, 2019
@iansu iansu changed the title [docs] revert removal of newlines from html Revert removal of newlines from html in docs Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JBallin @ianschmitz @iansu @facebook-github-bot