change class component to function component #6451
Conversation
|
Should we use named export in TypeScript？ |
Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>
xiaoxiangmoe
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
mrmckeb,
petetnt and
Timer
as code owners
Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>
| @@ -1,28 +1,26 @@ | |||
| import React, { Component } from 'react'; | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Wouldn't import React, { FC } from 'react'; be more consistent in spirit to the current class-based version?
There was a problem hiding this comment.
@denisw In TypeScript Doc it write:
import * as React from "react";Should we use named export rather than default export?
There was a problem hiding this comment.
Yes, import * as React is what you would need to do by default, but create-react-app's TypeScript configuration has allowSyntheticDefaultImports option enabled. From the documentation:
Allow default imports from modules with no default export. This does not affect code emit, just typechecking.
As the code emit part is taken care of by Babel here, import React "just works" the same way it does for the JavaScript setup.
|
Thanks! |
* masterd: (24 commits) Add TypeScript linting support (facebook#6513) Support React Hooks (facebook#5602) (facebook#5997) Support browserslist in @babel/preset-env (facebook#6608) Add empty mock for http2 (facebook#5686) Add note about npx caching (facebook#6374) change named import into default import (facebook#6625) Stage files for commit after ejecting (facebook#5960) Upgrade dependencies (facebook#6614) Make compiler variable const instead of let (facebook#6621) Type check JSON files (facebook#6615) Change class components to functional components in templates (facebook#6451) Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610) Update html-webpack-plugin (facebook#6361) Enable click to go to error in console for TypeScript (facebook#6502) Update webpack-dev-server to 3.2.1 (facebook#6483) [docs] revert removal of newlines from html (facebook#6386) Publish Prepare 2.1.8 release Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586) Publish ... # Conflicts: # packages/babel-preset-react-app/create.js # packages/react-scripts/scripts/build.js
No description provided.