chore(eslint): require curly brackets on all blocks (#2239)

facebook · Jan 24, 2020 · 894dbcf · 894dbcf
1 parent 42061c6
commit 894dbcf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -51,6 +51,7 @@ module.exports = {
  'jsx-a11y/no-noninteractive-element-interactions': WARNING,
  'no-console': OFF,
  'no-underscore-dangle': OFF,
+ curly: [WARNING, 'all'],
  'react/jsx-closing-bracket-location': OFF, // Conflicts with Prettier.
  'react/jsx-filename-extension': OFF,
  'react/jsx-one-expression-per-line': OFF,

diff --git a/packages/docusaurus-theme-classic/src/theme/DocItem/index.js b/packages/docusaurus-theme-classic/src/theme/DocItem/index.js
@@ -32,7 +32,9 @@ function DocTOC({headings}) {
 
 /* eslint-disable jsx-a11y/control-has-associated-label */
 function Headings({headings, isChild}) {
- if (!headings.length) return null;
+ if (!headings.length) {
+ return null;
+ }
  return (
  <ul className={isChild ? '' : 'contents contents__left-border'}>
  {headings.map(heading => (

diff --git a/packages/docusaurus/src/client/PendingNavigation.js b/packages/docusaurus/src/client/PendingNavigation.js
@@ -65,7 +65,9 @@ class PendingNavigation extends React.Component {
  } else {
  const id = hash.substring(1);
  const element = document.getElementById(id);
- if (element) element.scrollIntoView();
+ if (element) {
+ element.scrollIntoView();
+ }
  }
  })
  .catch(e => console.warn(e));