Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): require curly brackets on all blocks #2239

Merged
merged 1 commit into from
Jan 24, 2020
Merged

chore(eslint): require curly brackets on all blocks #2239

merged 1 commit into from
Jan 24, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 23, 2020

Motivation

As mentioned in the PR #2224 (comment) I decided that it was worth adding the corresponding rule to ESLint.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check code style.

@lex111 lex111 requested a review from yangshun January 23, 2020 17:39
@lex111 lex111 requested a review from wgao19 as a code owner January 23, 2020 17:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 23, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 31babb1

https://deploy-preview-2239--docusaurus-2.netlify.com

yangshun
yangshun approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yangshun yangshun merged commit 894dbcf into facebook:master Jan 24, 2020
@yangshun yangshun deleted the eslint-curly branch January 24, 2020 05:29
@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 31, 2020
@lex111 lex111 restored the eslint-curly branch April 18, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@wgao19 wgao19 Awaiting requested review from wgao19

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lex111 @docusaurus-bot @yangshun @facebook-github-bot