Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is clipped on mobile #385

Closed
Haroenv opened this issue Jan 9, 2018 · 5 comments
Closed

Search is clipped on mobile #385

Haroenv opened this issue Jan 9, 2018 · 5 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Haroenv
Copy link

Haroenv commented Jan 9, 2018

Hey there! Thanks for making docusaurus 👋

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Steps to Reproduce

  1. go to any of the websites using docusaurus
  2. use Safari
  3. open "responsive mode" (cmd-ctrl-r)
  4. type something in the search bar

Expected Behavior

The search results to take up most of the screen and have reasonable padding

Actual Behavior

The search results are truncated and don't take up the whole screen. They also overlap a bit with the title.

screen shot 2018-01-09 at 11 37 21

Reproducible Demo

https://docusaurus.io has this for example

@JoelMarcey JoelMarcey added the bug An error in the Docusaurus core causing instability or issues with its execution label Feb 27, 2018
@JoelMarcey
Copy link
Contributor

@Haroenv Thank you for this issue. Are you seeing this on Chrome too, btw?

@amyrlam
Copy link
Contributor

amyrlam commented May 23, 2018

I'm game to claim the issue!

Seems like the styling of the search bar has been fixed as we replaced the site title with just an icon when on mobile.

To clarify, it seems like we want the Algolia results to extend to a much larger height? Maybe if it's cut off at height x it can be cut off at the middle of a row as well so that it's clear it can scroll? I can play around with the design. Here's a gif of what I see right now:

search

I see this on Safari and Chrome.

@Haroenv
Copy link
Author

Haroenv commented May 23, 2018

I'd suggest to show it full width at least, and probably quite a bit longer so it doesn't need to scroll

@JoelMarcey JoelMarcey added the status: claimed Issue has been claimed by a contributor who plans to work on it. label May 23, 2018
@JoelMarcey
Copy link
Contributor

Thanks @amyrlam!

@amyrlam
Copy link
Contributor

amyrlam commented May 23, 2018

Thanks for the input - I'll tag you both on the PR, in case we need to workshop the design!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

No branches or pull requests

4 participants