-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Cross repo publishing #717
Comments
I'm willing to tackle this one if we agree on some way of implementing it. I'm happy with having an env flag like |
@gustavohenke |
A few ideas:
|
Tbh i think having to set an env flag and having to type My understanding is that you want separate code repository. One is the one that contains docs while another one is the published code (just the built html/css file). I think it's better to make it such that whether it's in the same repo / different repo, if I set my 'projectName' & 'organizationName` to something, I want my published codes (built HTML/CSS) to be there. What do you think ? |
As a developer, I find it valuable to have the docs in the same
repository. The docs changes are then in the same commits/branches as the
corresponding code changes.
The ability the generate the documentation website from more than one
repository wozld he very useful at my company, where we are not using a
monorepo.
…On Thu, Jun 7, 2018, 10:50 Endilie Yacop Sucipto ***@***.***> wrote:
Tbh i think having to set an env flag and having to type CROSS_REPO_PUBLISHING=true
docusaurus-publish is quite unnatural to do.
My understanding is that you want separate code repository. One is the one
that contains docs while another one is the published code (just the built
html/css file).
I think it's better to make it such that whether it's in the same repo /
different repo, if I set my 'projectName' & 'organizationName` to
something, I want my published codes (built HTML/CSS) to be there.
What do you think ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#717 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaetIKeNNRIicx3UsYX6zXAYCB-brxdks5t6OlTgaJpZM4UVXLc>
.
|
Do you think that this would be a super common use-case? If not, then I don't mind an environment variable that can be used and is documented (e.g., @gustavohenke naive flag idea). Otherwise, we should consider this some more -- maybe we still use the flag, but having something in the core code that works could be better. |
So this would mean simply removing the branch check, I guess?
I'm not sure. Perhaps? My points in favour of this cross repo publishing is
|
I've used cross repo publishing pattern.
Currently, I use shell script to deploy. |
I definitely think the most common case if having the raw docs and site close to the source code, but the built rendered HTML on We are definitely willing to consider a pull request that makes your use case easier for anyone who needs it, whether through a environment variable or a more substantial code change. |
Closed by #764 |
Is this a bug report?
No
Have you read the Contributing Guidelines on issues?
Skimmed through it, expect it to be the same as most other OSS projects
Environment
Docusaurus ^1.0.15
Steps to Reproduce + current behaviour
master
checked out..github.io
) that has no commits (important)After this, you'll get #406 thrown at your face.
The reason is that the publish script is not ready to deal with cross repo publishings.
It only knows how to deal within user sites (
master
publish target,source
as source branch) or project sites (gh-pages
publish target,master
as source branch).Expected
BehaviourFeatureHave some way of letting
docusaurus-publish
know we're doing a cross repo publishing.Reproducible Demo
express-validator org is such a setup.
Here's the
siteConfig.js
, it hasprojectName
set toexpress-validator.github.io
, but the code is not in the org site repo.When you go there, all you will see is the built HTML/CSS/etc.
The text was updated successfully, but these errors were encountered: