Fail properly when current branch is the same as the deployment one #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit 32f99c4 |
gustavohenke
force-pushed
the
branch-check
branch
from
f7724dc to
78fccde
Compare
Otherwise it may contain a trailing \n
gustavohenke
force-pushed
the
branch-check
branch
from
78fccde to
32f99c4
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
yangshun
approved these changes
Jun 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I actually wanted something else of the publish script, and was looking into submitting another PR.
Then I found this bug.
In the publish script, shelljs' command output that parses the current branch wasn't unwrapped nor trimmed.
This means that when checking if the deployment branch is the same as the current branch, it would be comparing
masterto{ stdout: 'master\n', stderr: '', ...etc }. Which isfalse, of course -- so the script would continue and cause #406.Have you read the Contributing Guidelines on pull requests?
Skimmed through it (it's 2am in Sydney now 😴), I expect it to be the same as most other OSS projects
Test Plan
Try publishing to an user/org site while you're on the
masterbranch. Or to a project site when you're ongh-pages...The boom 💥
Have you read any cryptic error messages today?
The fix 🤕
Ah, clear error message, fine! 😎