fix(v2): make feedback page compatible with dark mode #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* misc(v2): clean up work * misc(v2): rename components
* feat(v2): implement component overriding * siteDir theme overriding should work for > 1 level directory * fallback for essential component like Loading * rename default -> classic
* feat(v2): easier plugin theme components override * add context * refactor again * rename eject -> swizzle * nits
* feat(v2): Algolia search plugin * patch PR facebook#1440 (facebook#1441) * alternative implementation * typo * refactor noop * rename SearchAlgolia -> SearchBar * changes.md
…k#1442) * refactor(v2): move headerLinks -> themeConfig & rm dead code * rm -rf dead code
* chore(v2): add flow setup * nits * fix * add flow-typed * ignore compiled library * fix error * fix typing * fix module name mapper * setup for @docusaurus/core * dont try remove type without @flow * fix can't find @docusaurus/utils * fix test * remove obscure relative paths * more refactoring * add typing for server/load/theme.js * no need to ship .flow source
* feat(v2): meta description * add description for blog as well * fix non-descriptive text link * remove font awesome * switch front-matter -> gray-matter
* refactor(v2): blog data revamp * fix(v2): fix incorrect blog total count * misc: remove console.log * feat(v2): export frontMatter as an object within MDX file (facebook#1451) * refactor. Don't confuse metadata & frontmatter * export frontMatter in content itself * nits * nits name * dont truncate first four lines in blog
* feat(v2): blog tags * feat(v2): blog tags
* fix: right TOC should not strip special chars * nits
* fix(v2): handle non existent blog, docs, pages * nits
* feat(v2): list blog tags on posts * fix date handling on blog header * fix console log error due to non unique key
…ook#1468) * Make it clear where the `docs` folder is It was not clear, to the beginner user—who this tutorial is for—where the `docs` folder was . The only reason I know this is because I'm a beginner user and I tried for too many minutes to find the `docs` folder inside the `website` folder. I had this assumption because the previous example is offered under the assumption that you're in the `website` folder. Feel free to change the wording, I just want to make it clear where you should be looking, if you're new. * Update tutorial-create-pages.md
In this tutorial we assume that the user may or may not have used Node.js. It would follow then, based on how long it takes the "Linking dependencies" step to complete—243.61s for me—that we give them a hint that it might take a minute.
* doc: change tutorial git to suggest HTTPS Since we're instructing the user to create a new repository, it might be a safe bet to assume that they don't have their SSH keys set up. HTTPS might be a better option in this context. * docs: keep ssh add https @hongarc said, "How about keep `SSH` and add `HTTPS`." This is one way to do that. * Update tutorial-setup.md
In facebook#1468 we clarify where the `docs` folder is. Here, we make it clear where `sidebars.json` is.
* fix: missing cli commands * centralize
* feat(v2): move navbar config into themeConfig * misc: fix tests * fix: support external url for logo
* WiP: CLI docs * Tweak word choices for CLI docs - Use the word swizzle directly - Follow variable convention for shell * Resolve docs discussion * Update cli.md
* docs: fix typo for `docs` folder * docs: request change for facebook#1484 * Update api-doc-markdown.md
* docs: showcase user Idb * docs: showcase user Netconsd * docs: showcase user Redex
|
Deploy preview for docusaurus-2 ready! Built with commit 1d634dd |
|
Deploy preview for docusaurus-preview ready! Built with commit 1d634dd |
yangshun
approved these changes
Aug 4, 2019
yangshun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
UX issue in Feedback page, Low contrast text is not visible in Dark Mode
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Go to http://localhost:3000/feedback
And toggle to Dark Mode, CSS changes should be visible. The expected behavior is attached in the image below
Related PRs
NA