Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): make feedback page compatible with dark mode #1742

Merged
merged 62 commits into from
Aug 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
ca340b4
docs: make navbar less cluttered
yangshun May 4, 2019
8c04491
misc(v2): rename components (#1434)
yangshun May 4, 2019
421b09e
misc(v2): rename Blog components
yangshun May 4, 2019
74fdc5c
refactor(v2): remove page plugin component
yangshun May 5, 2019
a2cf3af
chore(v2): optimize webpack config
endiliey May 6, 2019
a635610
feat(v2): implement theme component overriding (#1435)
yangshun May 6, 2019
e94df5e
fix(v2): add missing layout alias on theme-classic plugin
endiliey May 6, 2019
fa3d64d
feat(v2): easier plugin theme components swizzling (#1436)
endiliey May 7, 2019
abb8433
fix(v2-cli): passes the missing host option to start (#1439)
May 8, 2019
57a017d
feat(v2): Algolia search theme (#1440)
yangshun May 8, 2019
6696489
refactor(v2): move headerLinks -> themeConfig & rm dead code (#1442)
endiliey May 8, 2019
ccc5143
chore(v2): better chunk naming
endiliey May 8, 2019
5f7b3fe
refactor(v2): add flowtype + refactor test (#1443)
endiliey May 8, 2019
bb0ebdd
chore(v2): rm flowtype (#1444)
endiliey May 9, 2019
4eae287
chore(v2): tweak eslint config (#1445)
endiliey May 9, 2019
84a8e23
chore: point website-1.x to correct version so that it can pick lates…
endiliey May 10, 2019
c49b5e5
feat(v2): meta description (#1447)
endiliey May 10, 2019
9060e0b
fix(v2): docsearch a11y issue (#1449)
endiliey May 11, 2019
fb6c1fc
refactor(v2): blog data revamp (#1450)
yangshun May 13, 2019
8c2b94e
fix(v2): transpiling, window scroll and console error (#1452)
endiliey May 13, 2019
5580a02
chore(v2): better error message style (#1454)
endiliey May 13, 2019
0ec47f3
chore(v2): remove docsearch a11y workaround
endiliey May 13, 2019
12a9ba5
feat(v2): blog tags (#1453)
yangshun May 13, 2019
36aacc8
fix(v2): slugify tags
yangshun May 13, 2019
e1a7fc5
chore(v2): use remark-slug so that rightToc can benefit from it
endiliey May 14, 2019
04c0ed0
fix: right TOC should not strip special chars (#1458)
endiliey May 14, 2019
614966f
fix(v2): handle non existent blog, docs, pages (#1459)
endiliey May 15, 2019
f51a653
feat(v2): list blog tags on posts (#1456)
yangshun May 15, 2019
0f358ad
test(v2): test different type of sidebar item
endiliey May 15, 2019
6d7582a
chore(v2): fix typo
endiliey May 15, 2019
f08ebb9
v2.0.0-alpha.14
endiliey May 15, 2019
22bf239
fix(v2): fix wrong dependency problem (#1460)
endiliey May 15, 2019
b4a71e4
v2.0.0-alpha.15
endiliey May 15, 2019
339ef8d
Chore(v2): use alias instead of relative path for blogpost
endiliey May 15, 2019
7f1995b
feat(v2): theme config for Footer (#1461)
yangshun May 16, 2019
5457ba5
chore(v2): update dependencies (#1462)
endiliey May 16, 2019
8a71da3
v2.0.0-alpha.16
endiliey May 16, 2019
41f1a3a
fix(v2): fix cannot import css from node_modules in userland (#1463)
endiliey May 16, 2019
a3c86c0
docs: showcase user Express Validator (#1464)
hong4rc May 16, 2019
6ee2891
docs: sort user with alphabetical (#1465)
hong4rc May 16, 2019
a36269b
chore: fix typo (#1466)
hong4rc May 16, 2019
2995157
docs: showcase user tipsi-stripe (#1423)
hong4rc May 16, 2019
845c733
docs: make it clear in the tutorial where the `docs` folder is (#1468)
TurekBot May 16, 2019
4463318
docs: add hint for linking dependencies time (#1470)
TurekBot May 17, 2019
b9fb0c5
doc: mention HTTPS approach in tutorial git clone step (#1471)
TurekBot May 17, 2019
b6d6def
docs: normalized spelling of `web server` (#1473)
hong4rc May 17, 2019
af8dee3
docs: clarify location of sidebars.json (#1472)
TurekBot May 17, 2019
9a53712
fix: missing cli commands (#1478)
endiliey May 17, 2019
be365a4
feat(v2): move navbar config into themeConfig (#1477)
yangshun May 17, 2019
36fb1ba
docs(v2): CLI docs (#1476)
wgao19 May 17, 2019
5d78cfc
fix(v2): should be able to build even if static folder doesnt exist (…
endiliey May 17, 2019
a17ee7f
chore: remove noWatch cli options because you cant disable watch in w…
endiliey May 17, 2019
f1d3f66
docs: update StreamPipes logo (#1481)
hong4rc May 17, 2019
0884f60
docs: showcase user Ax (#1483)
hong4rc May 17, 2019
add8205
docs: remove pinned for Taro (#1482)
hong4rc May 17, 2019
4ed3e93
docs: fix typo for `docs` folder (#1484)
May 17, 2019
8de36d2
docs: add some showcase user of `facebook` (#1486)
hong4rc May 17, 2019
d730e4a
Merge remote-tracking branch 'upstream/master'
shakcho May 18, 2019
a134493
Merge remote-tracking branch 'upstream/master'
shakcho May 18, 2019
165a8d1
Merge branch 'master' of https://github.com/facebook/Docusaurus
shakcho Jun 13, 2019
d4ad06e
Merge branch 'master' of https://github.com/facebook/Docusaurus
shakcho Aug 4, 2019
1d634dd
added css for feedback page contrast issue
shakcho Aug 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion website/src/css/custom.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
--ifm-color-primary-light: rgb(70, 203, 174);
--ifm-color-primary-lighter: rgb(102, 212, 189);
--ifm-color-primary-lightest: rgb(146, 224, 208);
--ifm-color-feedback-background: #fff;
}

html[data-theme='dark'] {
--ifm-color-feedback-background: #f0f8ff;
}

@media screen and (max-width: 996px) {
Expand All @@ -26,4 +31,3 @@
--ifm-font-size-base: 17px;
}
}

11 changes: 10 additions & 1 deletion website/src/pages/feedback/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import React, {useEffect} from 'react';
import Layout from '@theme/Layout';

import canny from '../../scripts/canny';
import classnames from 'classnames';
import styles from './styles.module.css';

const BOARD_TOKEN = '054e0e53-d951-b14c-7e74-9eb8f9ed2f91';

Expand All @@ -24,7 +26,14 @@ function Feedback() {

return (
<Layout permalink={'/feedback'} description={'Docusaurus 2 Feedback page'}>
<div className="container margin-vert--xl" data-canny />
<div
className={classnames(
'container',
'margin-vert--xl',
styles.feedbackBackground,
)}
data-canny
/>
</Layout>
);
}
Expand Down
12 changes: 12 additions & 0 deletions website/src/pages/feedback/styles.module.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* Copyright (c) 2017-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

.feedbackBackground {
padding: var(--ifm-spacing-horizontal);
border-radius: 4px;
background: var(--ifm-color-feedback-background);
}