refactor(v2): make better a11y for tabs #1990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tabs cannot be controlled from the keyboard at the moment, this is very bad for a11y.
This PR implements tab switching by Tab/Tab+Shift and arrow keys (left and right).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Additionally, I added an
onFocus
handler so as not to press the Enter button to open the content of the focusable tab. Because that the contents of all the tabs are already loaded, we can immediately display the contents of focusable tab, it's very cool.For comparison, an example without
onFocus
, where the user needs to press Enter to display the contents of focusable tab. I think in this case it is not very good for UX.