Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): make better a11y for tabs #1990

Merged
merged 2 commits into from
Nov 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions packages/docusaurus-theme-classic/src/theme/Tabs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,77 @@ import React, {useState, Children} from 'react';

import classnames from 'classnames';

import styles from './styles.module.css';

const keys = {
left: 37,
right: 39,
};

function Tabs(props) {
const {block, children, defaultValue, values} = props;
const [selectedValue, setSelectedValue] = useState(defaultValue);
const tabRefs = [];

const focusNextTab = (tabs, target) => {
const next = tabs.indexOf(target) + 1;

if (!tabs[next]) {
tabs[0].focus();
} else {
tabs[next].focus();
}
};

const focusPreviousTab = (tabs, target) => {
const prev = tabs.indexOf(target) - 1;

if (!tabs[prev]) {
tabs[tabs.length - 1].focus();
} else {
tabs[prev].focus();
}
};

const handleKeydown = (tabs, target, event) => {
switch (event.keyCode) {
case keys.right:
focusNextTab(tabs, target);
break;
case keys.left:
focusPreviousTab(tabs, target);
break;
default:
break;
}
};

return (
<div>
<ul
role="tablist"
aria-orientation="horizontal"
className={classnames('tabs', {
'tabs--block': block,
})}>
{values.map(({value, label}) => (
<li
className={classnames('tab-item', {
role="tab"
tabIndex="0"
aria-selected={selectedValue === value}
className={classnames('tab-item', styles.tabItem, {
'tab-item--active': selectedValue === value,
})}
key={value}
ref={tabControl => tabRefs.push(tabControl)}
onKeyDown={event => handleKeydown(tabRefs, event.target, event)}
onFocus={() => setSelectedValue(value)}
onClick={() => setSelectedValue(value)}>
{label}
</li>
))}
</ul>
<div className="margin-vert--md">
<div role="tabpanel" className="margin-vert--md">
{
Children.toArray(children).filter(
child => child.props.value === selectedValue,
Expand Down
10 changes: 10 additions & 0 deletions packages/docusaurus-theme-classic/src/theme/Tabs/styles.module.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* Copyright (c) 2017-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

.tabItem:focus {
background-color: var(--ifm-hover-overlay);
}