feat(v2): add isCloseable property for theme-classic announcement bar #3388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
User not always should be able to close the announcement bar. The decision should be on the docs creator side.
This PR adds
isCloseable
property to thetheme-classic
announcement bar options, which defaults totrue
, to retain the previous behavior.The documentation has been also updated within this PR.
I'm open to rename the property, this was the first, good idea which came to my mind. 🙂
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Change has been tested locally with Docusaurus V2 website.
Related PRs