WIP: Migrate from docusaurus v1 to v2 #2139

darshkpatel · 2020-08-12T18:13:45Z

The deploy preview is currently broken, so here's a copy of this branch deployed
https://deploy-preview-5--react-native-website-migration.netlify.app/

To do:

Fix SnackPlayer and Prism config
Update content tabs

Legend:

🔨 - in progress

- complete

react-native-bot · 2020-08-12T18:15:02Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

facebook-github-bot · 2020-08-12T18:25:56Z

Hi @darshkpatel!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

react-native-bot · 2020-08-12T19:46:17Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T05:28:08Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T05:28:09Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T06:49:23Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T06:49:25Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T07:06:40Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T18:49:54Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T19:15:47Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

Simek · 2020-08-13T20:06:39Z

.circleci/config.yml

@@ -4,9 +4,9 @@ version: 2.1
 #        EXECUTORS
 # -------------------------
 executors:
-  node8:
+  node10:


CI Node image has been updated to the LTS in #2140.

Cool. Maybe it would solve the memory issue 😝

@slorber LTS bump fixed that OOM issue it seems 🙂

Thank you for your help! 😄

react-native-bot · 2020-08-13T23:11:56Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-13T23:11:56Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T08:09:01Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

darshkpatel · 2020-08-14T09:45:48Z

🥳

Will try to fix the deploy preview too

darshkpatel · 2020-08-14T09:58:35Z

@Simek should i remove netlify-reduce-versions since the v2 site only has versions >0.60
or should i still keep it and change the filter to >v0.60

Simek · 2020-08-14T10:10:40Z

@darshkpatel I'm not familiar with this pipeline. You should ask @charpeni about that, he is responsible for the website previews. He also should be able to help you with fixing the preview deployment script.

darshkpatel · 2020-08-14T10:13:36Z

Removed the reduce-versions script since filtering >0.60 kind of defeats the whole purpose of the script. Lemme know if I should modify the script instead @charpeni

react-native-bot · 2020-08-14T10:19:16Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T12:57:00Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T13:02:28Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

darshkpatel · 2020-08-14T15:55:32Z

netlify.toml

@@ -1,4 +1,4 @@
 [build]
  base    = "v2-website"
  publish = "v2-website/build"
-  command = "sed -i -e \"s|const baseUrl .*|const baseUrl = '/'|g\" docusaurus.config.js && yarn install && yarn sync-community-repos && yarn build"


yarn sync-community-repos is needed to get the list of community repos, it's essential I believe.

yup, I was trying to see which part was causing the problem. I think I got it

guess not! 😅 I thought it was only because netlify was looking for v2-website/v2-website/build, but I'm still missing something else. I'll try again tmr
Anyway, I deployed a test site using the same netlify.toml (without the yarn sync-community-repos) here:
repo: https://github.com/teikjun/react-native-deploy
test site (netlify): https://react-native-v2.netlify.app/docs/
test site (vercel): https://react-native-deploy.vercel.app/docs/ (same thing)

Hey @teikjun, were you able to get the deploy preview working finally? Can I help?

Also, can you put the preview links at the top so that they are more easy to find ? :)

I couldn't figure out what was causing the deploy preview to fail, so we're using our own previews for now.
@darshkpatel has just added the preview links to his PR description at the top! :)

react-native-bot · 2020-08-14T16:10:31Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T16:52:49Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T16:52:50Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-14T16:58:51Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

s-pace · 2020-08-24T09:42:05Z

@Simek thank you for your feedback.

But I have a question: why (on the attached screenshot) yello matches hello query? 🙂

This is intended since Algolia search is typo tolerant. It will help your end users to find what they are looking for even if their query has a typo. For example, the query scrolview would still match scrollview (1 l instead of 2)

This reverts commit 6e2a698.

…ative-website into docs/v2-migration

darshkpatel · 2020-08-25T14:16:48Z

I've force-pushed the changes from an alternate branch which preserves contributions for /docs
Ref: #2146 (comment) , #2146 (comment)

darshkpatel · 2020-08-25T14:17:12Z

SnackPlayer also works now 🥳

react-native-bot · 2020-08-25T14:21:54Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-25T19:08:37Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-25T19:08:39Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

react-native-bot · 2020-08-25T19:17:47Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

slorber · 2020-08-28T08:39:37Z

Hey!

I've created this org and fork so that we can work on this migration in a more organized way:
https://github.com/react-native-website-migration/react-native-website

This doesn't close the modal when selecting the input text and finishing the selection outside of the modal. See facebook/react-native-website#2139 (comment)

Simek · 2020-09-02T12:49:21Z

Migrate landing page

@darshkpatel The homepage is empty right now - https://react-native-v2.netlify.app/.

Make changes to navbar

@darshkpatel There are several changes that are still required:

navbar should be dark in both themes (the only component/element which should change theme is search bar),
navbar components/sections should be in other order and only logo and versions link should be positioned to the left side,
ideally versions page link and versions selector should merged to one component.

slorber · 2020-09-02T16:28:19Z

Can be closed in favor in the new migration fork: react-native-website-migration#7

darshkpatel mentioned this pull request Aug 12, 2020

WIP: Migrate from docusaurus v1 to v2 MLH-Fellowship/react-native-website#37

Closed

16 tasks

facebook-github-bot added the CLA Signed label Aug 12, 2020

darshkpatel marked this pull request as draft August 13, 2020 06:54

Simek added the MLH Major League Hacking label Aug 13, 2020

Simek reviewed Aug 13, 2020

View reviewed changes

darshkpatel commented Aug 14, 2020

View reviewed changes

teikjun added 2 commits August 24, 2020 08:59

fix css variables

7a1fc4a

limit scope of css for landing page

7f88fb6

darshkpatel and others added 10 commits August 24, 2020 15:20

rewrite snackplayer with remark plugin

4f6ccad

update export for RemarkPlugin

6e2a698

Revert "update export for RemarkPlugin"

d241616

This reverts commit 6e2a698.

add tabs for a tabbed snack player

33dbca1

fix a tab list

8eed682

WIP: nested tabs POC

7ddddaa

fix config import error

753f0cb

Fix: Showcase page import

41bbbce

fix versions import

257f1c9

Merge branch 'docs/v2-migration' of github.com:MLH-Fellowship/react-n…

4019d4a

…ative-website into docs/v2-migration

darshkpatel force-pushed the docs/migration branch from 472cc5b to 4019d4a Compare August 25, 2020 14:15

anshul and others added 2 commits August 25, 2020 19:54

use alias for versions.json file

319da6a

WIP: attempt to fix OOM errors with build

8fd8183

Simek mentioned this pull request Sep 1, 2020

feat(v2): add isCloseable property for theme-classic announcement bar facebook/docusaurus#3388

Merged

slorber mentioned this pull request Sep 2, 2020

React-Native Website Migration Infos react-native-website-migration/react-native-website#7

Open

Simek closed this Sep 2, 2020

Simek mentioned this pull request Oct 20, 2020

Migrate React Native website to Docusaurus V2 #2263

Merged

WIP: Migrate from docusaurus v1 to v2 #2139

WIP: Migrate from docusaurus v1 to v2 #2139

Conversation

darshkpatel commented Aug 12, 2020 • edited Loading

react-native-bot commented Aug 12, 2020

facebook-github-bot commented Aug 12, 2020

react-native-bot commented Aug 12, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

Simek Aug 13, 2020

Choose a reason for hiding this comment

slorber Aug 13, 2020

Choose a reason for hiding this comment

Simek Aug 13, 2020

Choose a reason for hiding this comment

teikjun Aug 14, 2020

Choose a reason for hiding this comment

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 13, 2020

react-native-bot commented Aug 14, 2020

darshkpatel commented Aug 14, 2020 • edited Loading

darshkpatel commented Aug 14, 2020 • edited Loading

Simek commented Aug 14, 2020

darshkpatel commented Aug 14, 2020 • edited Loading

react-native-bot commented Aug 14, 2020

react-native-bot commented Aug 14, 2020

react-native-bot commented Aug 14, 2020

darshkpatel Aug 14, 2020 • edited Loading

Choose a reason for hiding this comment

teikjun Aug 14, 2020

Choose a reason for hiding this comment

teikjun Aug 14, 2020 • edited Loading

Choose a reason for hiding this comment

slorber Aug 17, 2020

Choose a reason for hiding this comment

teikjun Aug 17, 2020

Choose a reason for hiding this comment

react-native-bot commented Aug 14, 2020

react-native-bot commented Aug 14, 2020

react-native-bot commented Aug 14, 2020

react-native-bot commented Aug 14, 2020

s-pace commented Aug 24, 2020

darshkpatel commented Aug 25, 2020 • edited Loading

darshkpatel commented Aug 25, 2020

react-native-bot commented Aug 25, 2020

react-native-bot commented Aug 25, 2020

react-native-bot commented Aug 25, 2020

react-native-bot commented Aug 25, 2020

slorber commented Aug 28, 2020

Simek commented Sep 2, 2020

slorber commented Sep 2, 2020

darshkpatel commented Aug 12, 2020 •

edited

Loading

darshkpatel commented Aug 14, 2020 •

edited

Loading

darshkpatel commented Aug 14, 2020 •

edited

Loading

darshkpatel commented Aug 14, 2020 •

edited

Loading

darshkpatel Aug 14, 2020 •

edited

Loading

teikjun Aug 14, 2020 •

edited

Loading

darshkpatel commented Aug 25, 2020 •

edited

Loading