fix(v1): versioned_docs and skip-next-release relative path issue #3429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests? YES
Due to #1805, reduxjs/react-redux#1583 and reduxjs/react-redux#1588,
I think following codes keep only files in
docs/
directory and filter all files inversioned_docs
.https://github.com/facebook/docusaurus/compare/master...josephMG:fix/versioned_docs_relative_link?expand=1#diff-945e90ba000dd59353b89af45929efdeL70
After digging into these issues, I notice that
metadata.source
tracksversionFallback md
file path, andhtmlLink
will be the url of fallback version. So I add ametadata.versioned_source
meanscurrent version md
file path, andhtmlLink
will be the url of current version.https://github.com/facebook/docusaurus/compare/master...josephMG:fix/versioned_docs_relative_link?expand=1#diff-229712ff4ab11f33b4d6855bff2cc168L72
Test Plan
Fix Yarn test
Before: (See GIF or https://react-redux.js.org/)
After:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)