-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docusaurus #1638
Update docusaurus #1638
Conversation
Deploy preview for react-redux-docs ready! Built with commit 80ccd27 |
Hmm, do we want to upgrade to 2.0? Everything appears A-OK, but we would be using the legacy theme. |
Yes, I definitely want us to upgrade to DS v2! Just a question of whether the upgrade correctly handles all the versioning aspects we're using from v1 or not. |
Hmm. This PR only seems to bump the DS version. Based on the work upgrading the Redux core docs from DSv1 to v2, I would expect this also requires a number of changes to the Docusaurus config files as well. @josephMG , can you review the Docusaurus config files from https://github.com/reduxjs/redux/tree/master/website and https://github.com/reduxjs/redux-toolkit/tree/master/website and see what config changes need to be applied here as well? I assume that |
Yes I only upgrade version to DSv2. I think it still run DSv1 because I only modify @markerikson Let me try it. I'm glad to help the rest of things to DSv2. |
@josephMG hey, this is looking great so far! The PR preview is definitely using DS v2 now, and it looks like the versioning is (hopefully?) cooperating. Will need to get the theme colors updated to match the other sites, and both the RTK and Redux core docs have a bunch of extra custom CSS that I'd like to pull over. Loving where this is going, and thank you! |
@markerikson I fixed styles to match both the RTK and Redux. Btw, please notice these two things:
|
Great! It's looking fairly close. Only thing I really see atm is that the "features" section should have a white background, not Also, we should be able to add a |
@markerikson Yes, I fixed features section color. |
Awright, this looks good enough for now. Let's merge it, and we can always fix any other issues later. @josephMG, thank you for doing this! :) |
Fix #1583 and #1588 by upgrade docusaurus.
Refs: