Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): various fixes #3587

Merged
merged 2 commits into from
Oct 16, 2020
Merged

refactor(v2): various fixes #3587

merged 2 commits into from
Oct 16, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 14, 2020

Motivation

Just some fixes.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Oct 14, 2020
@lex111 lex111 requested a review from slorber as a code owner October 14, 2020 17:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 14, 2020
@@ -4,7 +4,7 @@
"theme_color": "#2196f3",
"background_color": "#424242",
"display": "standalone",
"scope": "",
"scope": "/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes this error:

Manifest: property 'scope' ignored. Start url should be within scope of scope URL.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also breaks the PWA installation on the preview ^^

https://deploy-preview-3587--docusaurus-2.netlify.app/classic/

As the scope is relative to manifest, I guess "" means "/classic/manifest.json".

Maybe "./" would work, as it would lead to "/classic/" ? worth trying

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "./" would work

Did this, can you confirm that it worked?

module.exports = function (context, options) {
return {
name: 'custom-docusaurus-plugin',
// highlight-start
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More flexible way to keep highlighted proper lines.

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 14, 2020

Deploy preview for docusaurus-2 ready!

Built with commit ba97fbe

https://deploy-preview-3587--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Oct 16, 2020

LGTM, the PWA + button seems back

image

Let's merge and hope it does not break in production 🤪 but should be fine

@slorber slorber merged commit bfefc46 into master Oct 16, 2020
@lex111 lex111 deleted the lex111/imp branch October 16, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants