-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v2): various fixes #3587
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
"theme_color": "#2196f3", | ||
"background_color": "#424242", | ||
"display": "standalone", | ||
"scope": "", | ||
"scope": "/", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes this error:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also breaks the PWA installation on the preview ^^ https://deploy-preview-3587--docusaurus-2.netlify.app/classic/ As the scope is relative to manifest, I guess "" means "/classic/manifest.json". Maybe "./" would work, as it would lead to "/classic/" ? worth trying There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Did this, can you confirm that it worked? |
||
"start_url": "./index.html", | ||
"icons": [ | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More flexible way to keep highlighted proper lines.