-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): CI scripts cleanup, add Node 14 runs, bump checkout action #3849
chore(ci): CI scripts cleanup, add Node 14 runs, bump checkout action #3849
Conversation
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit b32bf8e |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3849--docusaurus-2.netlify.app/classic/ |
Size Change: +21 B (0%) Total Size: 157 kB ℹ️ View Unchanged
|
Changing Node from
|
Thanks, seems to be fine for now, but we'll try to figure out these issues you reported |
Motivation
This PR clean up the GitHub action workflow files and adds Node 14 run to the "Yarn v1 E2E" run and Node 15 to the "Yarn v2 E2E" run to ensure that not only the minimal version of Node, but also
Active LTS
andCurrent
do no produce any errors for the users.I have also bumped all the remaining
actions/checkout@v1
tov2
- some of workflows were already usingv2
. Also the Node version declaration has been updated to the recommended syntax - https://github.com/actions/setup-node.Additionally I have moved the Yarn version set command at the beginning of script so initial installation would also be performed using Yarn v2.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Need to run the CI.
Related PRs
No.