Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): CI scripts cleanup, add Node 14 runs, bump checkout action #3849

Merged
merged 12 commits into from
Dec 1, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 30, 2020

Motivation

This PR clean up the GitHub action workflow files and adds Node 14 run to the "Yarn v1 E2E" run and Node 15 to the "Yarn v2 E2E" run to ensure that not only the minimal version of Node, but also Active LTS and Current do no produce any errors for the users.

I have also bumped all the remaining actions/checkout@v1 to v2 - some of workflows were already using v2. Also the Node version declaration has been updated to the recommended syntax - https://github.com/actions/setup-node.

Additionally I have moved the Yarn version set command at the beginning of script so initial installation would also be performed using Yarn v2.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Need to run the CI.

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 30, 2020
@netlify
Copy link

netlify bot commented Nov 30, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit b32bf8e

https://deploy-preview-3849--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 30, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3849--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Nov 30, 2020

Size Change: +21 B (0%)

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB 0 B
website/build/main.********.js 113 kB +21 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@Simek Simek marked this pull request as draft November 30, 2020 19:33
@Simek
Copy link
Contributor Author

Simek commented Dec 1, 2020

Changing Node from 15 to 14 resolved the Yarn v2 E2E workflow issue, it look like this PR brought to table two problems:

  • Yarn v2 do not work with the Docusaurus workspace so contributors using it by default would struggle (but it will work for the users and might work for few, single packages) - it's also nice that you can switch between the Yarn versions that fast
  • init do not work correctly on Node 15, which is shipped with NPM 7 by default, this might be due to:

@Simek Simek marked this pull request as ready for review December 1, 2020 11:52
@Simek Simek changed the title chore(ci): CI scripts cleanup, add Node 14 and 15 runs, bump checkout action chore(ci): CI scripts cleanup, add Node 14 runs, bump checkout action Dec 1, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 1, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 1, 2020

Thanks, seems to be fine for now, but we'll try to figure out these issues you reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants