Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Yarn v2 cache directory to ignores #3860

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Dec 1, 2020

Motivation

It looks like it .yarn directory should also be added to the .eslintignore and .prettierignore, because currently some of build commands includes formatting steps, and some unnecessary files are being reformatted.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Local test run of Docuausurs workspace using Yarn v2.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 1, 2020
@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 6231c1c

https://deploy-preview-3860--docusaurus-2.netlify.app

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 1, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 1, 2020

👍

@slorber slorber merged commit 7d0b451 into facebook:master Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3860--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

Size Change: +20 B (0%)

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.84 kB +1 B
website/build/main.********.js 113 kB +20 B (0%)
website/build/styles.********.css 17.5 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants