chore: Enable ESLint rules of hooks + fix new lint errors

[slorber]

Motivation

Enable missing React rules of hook ESLint plugin

Fixes 22 reported errors:

• some were easy fixes
• some more complicated and required introducing some React utils to deal with unstable callbacks and stale closures (see also Design decision: why do we need the stale closure problem in the first place? react#16956)

Will need some non-regression testing, in particular, worth testing:

• link prefetching
• scroll-related features
• Search page

[netlify]

✔️ [V2]

🔨 Explore the source changes: ef656a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61699bdeaffe1d0007428b4d

😎 Browse the preview: https://deploy-preview-5714--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	94
🟢 Accessibility	98
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-5714--docusaurus-2.netlify.app/

[github-actions]

Size Change: +245 B (0%)

Total Size: 885 kB

Filename	Size	Change
website/build/assets/js/main.********.js	457 kB	+239 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
website/.docusaurus/globalData.json	50.5 kB	0 B
website/build/assets/css/styles.********.css	93.8 kB	0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html	67.4 kB	0 B
website/build/blog/index.html	38.2 kB	0 B
website/build/docs/index.html	45.3 kB	+3 B (0%)
website/build/docs/installation/index.html	53.1 kB	+3 B (0%)
website/build/index.html	30.8 kB	0 B
website/build/tests/docs/index.html	26.3 kB	0 B
website/build/tests/docs/standalone/index.html	23 kB	0 B

_{compressed-size-action}

[slorber]

oh noh, just broke the search page 😓

[lex111]

@slorber I just noticed that this change negatively affects on the hideable sidebar feature. After location change (I suppose), while closing a sidebar, the current scroll position is reset to zero, i.e. a page scrolls to the top.

Actual behavior:

ezgif.com-gif-maker.mp4

Expected behavior

ezgif.com-gif-maker.1.mp4

Could you please see how this can be fixed?