fix: stable callbacks in useSearchQuery + refactor #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: breaking change
|
✔️ [V2] 🔨 Explore the source changes: 6671ff3 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6170311fd4a1f50008250885 😎 Browse the preview: https://deploy-preview-5751--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5751--docusaurus-2.netlify.app/ |
|
Size Change: +6 B (0%) Total Size: 843 kB ℹ️ View Unchanged
|
slorber
changed the title
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: the returned value of
useSearchQueryhas been updatedMotivation
This PR introduced a SearchPage regression: #5714
https://docusaurus.io/search
Unmemoized callbacks in
useSearchQuerylead to infinite render loops.This PR memoize the callbacks to fix the bug + refactor a little bit
useSearchQuery+SearchPageto avoid some useless duplicated search query state (more refactorings should be done on the search page)Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview