Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have cocoapods rebuild FacebookSDKStrings.bundle so xcode processes strings files #1713

Closed
wants to merge 2 commits into from
Closed

Have cocoapods rebuild FacebookSDKStrings.bundle so xcode processes strings files #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88125ba
Have cocoapods rebuild FacebookSDKStrings.bundle so xcode processes s…
cltnschlosser Apr 10, 2021
6a30ea8
Add changelog entry
cltnschlosser Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Important

**Performance Improvements**

- Cocoapods: FBSDKCoreKit rebuilds FacebookSDKStrings.bundle so xcode processes the strings files into binary plist format. This strips comments and saves ~181KB in disk space for apps. [#1713](https://github.com/facebook/facebook-ios-sdk/pull/1713)

[Full Changelog](https://github.com/facebook/facebook-ios-sdk/compare/v9.2.0...HEAD)

## 9.2.0
Expand Down
2 changes: 1 addition & 1 deletion FBSDKCoreKit.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Pod::Spec.new do |s|
'FBSDKCoreKit/FBSDKCoreKit/GraphAPI/*.h'
ss.private_header_files = 'FBSDKCoreKit/FBSDKCoreKit/Internal/**/*.h',
'FBSDKCoreKit/FBSDKCoreKit/AppEvents/Internal/**/*.h'
ss.resources = 'FacebookSDKStrings.bundle'
ss.resource_bundles = { 'FacebookSDKStrings' => ['FacebookSDKStrings.bundle/**/*.strings'] }
ss.library = 'c++', 'stdc++'
end
end