Switch to isomorphic-fetch

[zpao]

Fixes #60

This should be pretty safe. With browserify and webpack packaging, this will use whatwg-fetch (exactly the same code we had).

[zpao]

Hmm, this actually needs a little bit more… going to try to actually build relay first (are some issues atm)

[zpao]

Ok, confirmed we're all good with facebook/relay#393.

I'm not wild about the versioning here. I didn't think about changes like this to fbjs needing corresponding bumps in fbjs-scripts. Oh well, we'll bump minors for both here.

[zpao]

cc @boourns - can you test this branch again with RN? I'm hoping by preempting the require we can still export something useful if it exists.

[boourns]

I will try it tonight or early tomorrow.

On Wednesday, 30 September 2015, Paul O’Shannessy notifications@github.com
wrote:

cc @boourns https://github.com/boourns - can you test this branch again
with RN? I'm hoping by preempting the require we can still export something
useful if it exists.

—
Reply to this email directly or view it on GitHub
#61 (comment).

[boourns]

OK. This PR does not work on react native currently.

After some debugging I've found that the problem is the @providesModule fetch line here:
https://github.com/zpao/fbjs/blob/isomorphic-fetch/src/__forks__/fetch.js#L9

I don't quite understand why, but with @providesModule in place, the rest of ./fetch.js is never executed when fetchWithRetries.js requires ./fetch (you can confirm this with a console.log). And what's returned by require('./fetch') in fetchWithRetries.js is a module object that looks like it has the fetch method available as fetch.fetch:

With the @providesModule line removed, ./fetch.js runs as expected, exports the fetch function, and this PR functions as desired on react native.

[boourns]

@zpao did my feedback make sense?

[denvned]

Is the problem described by @boourns still actual? Are there any other problems that prevent this from being merged?

[jeswin]

+1 to getting this merged. Server-side Relay takes a lot of manual patching right now.

[sophiebits]

Happened in #95.