Build 2x faster #393
Closed
Build 2x faster #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| loaders: [ | ||
| {test: /\.js$/, loader: 'babel'} | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Ok, I'll come clean…
The real reason I found this was because I couldn't build relay after making changes to fbjs because babel didn't like transforming the code it generated and I got this:
ERROR in Loader /Users/poshannessy/FB/code/fbjs/node_modules/babel/index.js didn't return a function
@ ../fbjs/lib/fetchWithRetries.js 26:27-60
|
Thanks! @facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/888826177831498/int_phab to review. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing some fbjs changes and got tired of waiting ~23s for each build so I made it faster.
Removed duplicate
modulestask. We already run it fordistanddist:min(where it gets deduped) so we don't need to run it before then.(saves ~5s)
Removed the babel webpack loader. We've already transformed our code.
fbjsis already transformed. We shouldn't need to transform again. There are some differences (https://gist.github.com/zpao/16e13b4a85010c6fbdff) as a result of this - mostly because we don't reprint, though there are also a couple'use strict'statements missing but that's probably ok.(saves ~6-7s for each
distanddist:minbut they run in parallel so only see the win once)I ran a few times before and after to get some stable numbers with a warm disk cache. I dropped from 23s to 12s.