Add buffer class to node.js interface #108
Conversation
| slice(start?: number, end?: number): Buffer; | ||
| fill(value: string | number, offset?: number, end?: number): void; | ||
| inspect(): string; | ||
| toString(encoding?: string, start?: number, end?: number): string; |
There was a problem hiding this comment.
The toString override here did not have the effect I was expecting.
The following still passes flow check even after the changes:
/* @flow */
function test(): string {
var buf = new Buffer('a');
return buf.toString({}, {}, {})
}Is this expected behavior?
|
toString is currently special-cased to accept anything and return true. |
| @@ -8,7 +8,59 @@ | |||
| * | |||
| */ | |||
|
|
|||
| type Buffer = any; // TODO | |||
| declare class Buffer { | |||
| constructor(value: Array<number> | number | string, encoding?: string): void; | |||
There was a problem hiding this comment.
It seems worthwhile to use overloading here at least for the (str, encoding) constructor -- since the other two versions of the constructor don't have a second parameter.
There was a problem hiding this comment.
I had initially tried that approach, but found that the type system was not behaving as I thought it would with overloaded constructors.
For example, given a declaration like this:
declare class Buffer {
constructor(array: Array<number>): void;
constructor(size: number): void;
constructor(string: string, encoding?: string): void;
}The following was still passing type check:
/* @flow */
var b = new Buffer(null)
|
This is awesome, thanks for doing this! |
Add buffer class to node.js interface
…sions fix loc.end for JSXEmptyExpression
No description provided.