Some more node std libs #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| declare module "dgram" { | ||
| declare function createSocket(type: string, callback?: () => void): void; |
There was a problem hiding this comment.
Should this return dgram$Socket?
|
Overlap with #108 on Buffer, how do we want to resolve this? |
|
I'll remove my Buffer impl and comment on a few things I see in that one |
|
OK, at first glance it seems you have more stuff in there, so I wouldn't just delete yours. Maybe try to merge? |
|
I ran through and compared -- it looks like I actually got a couple things wrong (I verified any discrepancies I saw). Anyway, I commented on that PR with any issues I saw there -- so going to remove from here now |
jeffmo
force-pushed
the
node_std_libs
branch
from
2275f57
to
6c9afe4
Compare
jeffmo
force-pushed
the
node_std_libs
branch
from
6c9afe4
to
99a3d8b
Compare
jeffmo
force-pushed
the
node_std_libs
branch
from
99a3d8b
to
e23a5a2
Compare
| @@ -217,19 +217,149 @@ declare module "crypto" { | |||
| ): void; | |||
| } | |||
|
|
|||
| type dgram$Socket = { | |||
There was a problem hiding this comment.
dgram.Socket inherits from EventEmitter
There was a problem hiding this comment.
Oh good catch, I'll circle back on this in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few more node module type signatures (
Buffer,dgram,dns,domain, andevents)