Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【igl nanovg part-2】Core Implementation #217

Closed
wants to merge 18 commits into from

Conversation

vinsentli
Copy link
Contributor

@vinsentli vinsentli commented Nov 26, 2024

This is the core implementation.

And this is a prerequisite pull request for igl nanovg(#213).

@vinsentli vinsentli changed the title iglu | nanovg | implement 【igl nanovg part-2】iglu | nanovg | implement Nov 26, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | implement 【igl nanovg part-2】iglu | nanovg | Implementation Nov 26, 2024
@vinsentli vinsentli marked this pull request as draft November 28, 2024 04:05
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | Implementation 【igl nanovg part-2】iglu | nanovg | Core Implementation Nov 29, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | Core Implementation 【igl nanovg part-2】Core Implementation Nov 29, 2024
@vinsentli vinsentli marked this pull request as ready for review November 29, 2024 12:59
@vinsentli vinsentli marked this pull request as draft November 29, 2024 13:01
@vinsentli vinsentli marked this pull request as ready for review December 2, 2024 02:03
@vinsentli vinsentli marked this pull request as draft December 2, 2024 02:03
@vinsentli vinsentli marked this pull request as ready for review December 2, 2024 03:30
Copy link
Contributor

@corporateshark corporateshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new CMake option IGLU_WITH_NANOVG (default: off) to control this new IGLU module.

This new option should be declared inside the root file CMakeLists.txt.

@vinsentli
Copy link
Contributor Author

Please add a new CMake option IGLU_WITH_NANOVG (default: off) to control this new IGLU module.

This new option should be declared inside the root file CMakeLists.txt.

done

IGLU/CMakeLists.txt Outdated Show resolved Hide resolved
…here the total size of uniform buffers cannot exceed 64K.
@facebook-github-bot
Copy link
Contributor

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@corporateshark
Copy link
Contributor

After internal discussion, we have decided not to add NanoVG as an IGLU module due to its incompatibility with our contribution guidelines. One of our primary design objectives is to minimize the number of dependencies within IGL itself. We will only accept new third-party dependencies if they are crucial to the core functionality of the IGL project. This ensures that we avoid creating unnecessary burdens on our team for future support and testing.

You are welcome to create your own standalone wrapper for NanoVG. This can be a separate repository for the NanoVG IGLU module, where our IGL repository is treated as a submodule. We are more than happy to discuss IGL bug fixes and issues related to it.

Before creating new PRs, please review our contributor guidelines and consider opening a GitHub issue first to determine whether your PR can be potentially accepted.

@vinsentli
Copy link
Contributor Author

It is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants