-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【igl nanovg part-2】Core Implementation #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new CMake option IGLU_WITH_NANOVG
(default: off) to control this new IGLU module.
This new option should be declared inside the root file CMakeLists.txt
.
revert shell/CMakeList.txt
done |
…here the total size of uniform buffers cannot exceed 64K.
@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
After internal discussion, we have decided not to add NanoVG as an IGLU module due to its incompatibility with our contribution guidelines. One of our primary design objectives is to minimize the number of dependencies within IGL itself. We will only accept new third-party dependencies if they are crucial to the core functionality of the IGL project. This ensures that we avoid creating unnecessary burdens on our team for future support and testing. You are welcome to create your own standalone wrapper for NanoVG. This can be a separate repository for the NanoVG IGLU module, where our IGL repository is treated as a submodule. We are more than happy to discuss IGL bug fixes and issues related to it. Before creating new PRs, please review our contributor guidelines and consider opening a GitHub issue first to determine whether your PR can be potentially accepted. |
It is OK. |
This is the core implementation.
And this is a prerequisite pull request for igl nanovg(#213).