FB8-181: Maintain a whitelist of semi-sync slaves which can ACK transactions #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percona-ysorokin
suggested changes
Apr 25, 2019
laurynas-biveinis
suggested changes
Apr 26, 2019
inikep
force-pushed
the
FB8-181
branch
4 times, most recently
from
b017400
to
3141b3d
Compare
|
All comments including |
inikep
force-pushed
the
FB8-181
branch
4 times, most recently
from
7d6bc62
to
8d44262
Compare
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
reviewed
May 15, 2019
|
@inikep has updated the pull request. Re-import the pull request |
|
PR was updated: using server_uuid instead of server_id in the semi-sync plugin |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@inikep has updated the pull request. Re-import the pull request |
|
@inikep has updated the pull request. Re-import the pull request |
|
@inikep has updated the pull request. Re-import the pull request |
|
@inikep has updated the pull request. Re-import the pull request |
|
@inikep has updated the pull request. Re-import the pull request |
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
…actions (percona#1017) (percona#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook/mysql-5.6@ee761fc Reference Patch: facebook/mysql-5.6@68f34521e82 Reference Patch: facebook/mysql-5.6@dfb038d48d0 Reference Patch: facebook/mysql-5.6@de1e8c7bfe7 Reference Patch: facebook/mysql-5.6@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook/mysql-5.6#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…actions (percona#1017) (percona#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook/mysql-5.6@ee761fc Reference Patch: facebook/mysql-5.6@68f34521e82 Reference Patch: facebook/mysql-5.6@dfb038d48d0 Reference Patch: facebook/mysql-5.6@de1e8c7bfe7 Reference Patch: facebook/mysql-5.6@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook/mysql-5.6#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 13, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…actions (facebook#1017) (facebook#1017) Summary: Jira issue: https://jira.percona.com/browse/FB8-181 Reference Patch: facebook@ee761fc Reference Patch: facebook@68f34521e82 Reference Patch: facebook@dfb038d48d0 Reference Patch: facebook@de1e8c7bfe7 Reference Patch: facebook@26835a39459 A whitelist of semi-sync slaves can be maintained using a new sys-var `rpl_semi_sync_master_whitelist`. The value of this variable is a comma separated list of UUIDs. ACK from any slave which is not in the whitelist will be ignored. The whitelist is persisted in file `semi_sync_master_whitelist.info` to survive server restarts. Porting notice: You have to use `set persist.rpl_semi_sync_master_whitelist` to keep value across server restarts. Originally Reviewed By: Tema Pull Request resolved: facebook#1017 Differential Revision: D15285223 Pulled By: yizhang82 -------------------------------------------------------------------------- Fix rpl.rpl_semi_sync_master_whitelist test in valgrind Summary: Increase the retry counts for valgrind runs. Also increase the shutdown_timeout for valgrind runs to give more time for shutdown to complete. Reviewed By: Pushapgl Differential Revision: D33359920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jira issue: https://jira.percona.com/browse/FB8-181
Reference Patch: ee761fc
Reference Patch: 68f34521e82
Reference Patch: dfb038d48d0
Reference Patch: de1e8c7bfe7
Reference Patch: 26835a39459
A whitelist of semi-sync slaves can be maintained using a new sys-var
rpl_semi_sync_master_whitelist. The value of this variable is a commaseparated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
semi_sync_master_whitelist.infoto survive server restarts.Porting notice:
You have to use
set @@persist.rpl_semi_sync_master_whitelistto keepvalue across server restarts.
TO DO: Because of conflicts I removed changes in
mysql-test/t/all_persisted_variables.test.This test has to be modified at
let $total_persistent_vars=XXX;(+1 increase)and it should be re-recorded.
Originally Reviewed By: Tema