Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG#14221043: MYSQL_UPGRADE FAILS WHEN SERVER IS RUNNING WITH GTID-MO… #1017

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

laurynas-biveinis
Copy link
Contributor

…DE=ON

mysql_upgrade fails when server is running with gtid_mode=ON and
--disable-gtid-unsafe-statements because system tables are stored
using MyISAM.

Changed default logging behaviour of mysql_upgrade, disabling it
by default. Logging can still be enable using the option
--write-binlog.
Actions taken by mysql_upgrade depend on the server version, them
should not be replicated to slaves.

http://jenkins.percona.com/job/percona-server-5.5-param/1385/

…DE=ON

mysql_upgrade fails when server is running with gtid_mode=ON and
--disable-gtid-unsafe-statements because system tables are stored
using MyISAM.

Changed default logging behaviour of mysql_upgrade, disabling it
by default. Logging can still be enable using the option
--write-binlog.
Actions taken by mysql_upgrade depend on the server version, them
should not be replicated to slaves.
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurynas-biveinis laurynas-biveinis merged commit d4585f0 into percona:5.5 Sep 15, 2016
@laurynas-biveinis laurynas-biveinis deleted the bug1065841-5.5 branch September 15, 2016 15:13
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 23, 2020
…actions (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set @persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Reviewed By: yizhang82

Differential Revision: D15285223

Pulled By: yizhang82

fbshipit-source-id: 87fc3ba56d5
inikep pushed a commit to inikep/percona-server that referenced this pull request Feb 24, 2021
…actions (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set @persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Reviewed By: yizhang82

Differential Revision: D15285223

Pulled By: yizhang82

fbshipit-source-id: 87fc3ba56d5
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 15, 2021
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223 (facebook/mysql-5.6@b5d9d04)

Pulled By: yizhang82

fbshipit-source-id: c638d32de0f
ldonoso pushed a commit to ldonoso/percona-server that referenced this pull request Mar 15, 2022
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82
ldonoso pushed a commit to ldonoso/percona-server that referenced this pull request Mar 15, 2022
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82
ldonoso pushed a commit to ldonoso/percona-server that referenced this pull request Mar 18, 2022
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82
ldonoso pushed a commit to ldonoso/percona-server that referenced this pull request Apr 12, 2022
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82

--------------------------------------------------------------------------

Fix rpl.rpl_semi_sync_master_whitelist test in valgrind

Summary:
Increase the retry counts for valgrind runs.

Also increase the shutdown_timeout for valgrind runs to give more time
for shutdown to complete.

Reviewed By: Pushapgl

Differential Revision: D33359920

fbshipit-source-id: 68210acc3a6
inikep added a commit to inikep/percona-server that referenced this pull request Apr 16, 2024
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82

--------------------------------------------------------------------------

Fix rpl.rpl_semi_sync_master_whitelist test in valgrind

Summary:
Increase the retry counts for valgrind runs.

Also increase the shutdown_timeout for valgrind runs to give more time
for shutdown to complete.

Reviewed By: Pushapgl

Differential Revision: D33359920
inikep added a commit to inikep/percona-server that referenced this pull request Apr 17, 2024
…actions (percona#1017) (percona#1017)

Summary:
Jira issue: https://jira.percona.com/browse/FB8-181

Reference Patch: facebook/mysql-5.6@ee761fc
Reference Patch: facebook/mysql-5.6@68f34521e82
Reference Patch: facebook/mysql-5.6@dfb038d48d0
Reference Patch: facebook/mysql-5.6@de1e8c7bfe7
Reference Patch: facebook/mysql-5.6@26835a39459

A whitelist of semi-sync slaves can be maintained using a new sys-var
`rpl_semi_sync_master_whitelist`. The value of this variable is a comma
separated list of UUIDs. ACK from any slave which is not in the whitelist will
be ignored. The whitelist is persisted in file
`semi_sync_master_whitelist.info` to survive server restarts.

Porting notice:
You have to use `set persist.rpl_semi_sync_master_whitelist` to keep
value across server restarts.

Originally Reviewed By: Tema
Pull Request resolved: facebook/mysql-5.6#1017

Differential Revision: D15285223

Pulled By: yizhang82

--------------------------------------------------------------------------

Fix rpl.rpl_semi_sync_master_whitelist test in valgrind

Summary:
Increase the retry counts for valgrind runs.

Also increase the shutdown_timeout for valgrind runs to give more time
for shutdown to complete.

Reviewed By: Pushapgl

Differential Revision: D33359920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants