Skip to content

Conversation

@sbuggay
Copy link

@sbuggay sbuggay commented Oct 22, 2025

Summary

Allow RNDT to append frames and screenshots, if the trace contains those events.

Test plan

Tested locally against an RN build that emits these events.

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

Removes fork.

@meta-cla meta-cla bot added the cla signed label Oct 22, 2025
@sbuggay sbuggay requested a review from hoxyq October 22, 2025 21:54
Copy link

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was a fork, we don't need to upstream this, I've updated the summary.

In terms of sequencing this work, it should probably be like this:

  1. Land support for frames in RN.
  2. Update the fork so that Frames track is appended, but screenshots checkbox is still hidden.
  3. Sync the frontend.
  4. Land support for screenshots in RN.
  5. Remove the fork completely.
  6. Sync the frontend.

I think your current change will just append the track, but the checkbox will still be hidden, right? So you implemented step [2] here?

Also, could you please remove the isReactNative field from the class, I believe it is unused now?

@sbuggay
Copy link
Author

sbuggay commented Oct 22, 2025

@hoxyq
Removed references to isReactNative.
Agreed on sequencing. Yes this change is only step 2 and has no affect on the screenshots checkbox.

Copy link

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I think we would also need to add support for parsing enabled categories in Tracing.start method, which would be the source of truth if user requested capturing screenshots or not.

@sbuggay sbuggay changed the title Remove RN exclusion for frames and screenshots Add experiment for enabling frames and screenshots Nov 3, 2025
@sbuggay sbuggay requested a review from huntie November 3, 2025 08:26
@sbuggay sbuggay requested a review from huntie November 3, 2025 21:15
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants