-
Notifications
You must be signed in to change notification settings - Fork 17
Add experiment for enabling frames and screenshots #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this was a fork, we don't need to upstream this, I've updated the summary.
In terms of sequencing this work, it should probably be like this:
- Land support for frames in RN.
- Update the fork so that Frames track is appended, but screenshots checkbox is still hidden.
- Sync the frontend.
- Land support for screenshots in RN.
- Remove the fork completely.
- Sync the frontend.
I think your current change will just append the track, but the checkbox will still be hidden, right? So you implemented step [2] here?
Also, could you please remove the isReactNative field from the class, I believe it is unused now?
|
@hoxyq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I think we would also need to add support for parsing enabled categories in Tracing.start method, which would be the source of truth if user requested capturing screenshots or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Allow RNDT to append frames and screenshots, if the trace contains those events.
Test plan
Tested locally against an RN build that emits these events.
Upstreaming plan
Removes fork.
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.