Skip to content

Add experiment for enabling frames and screenshots #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+12 −8
Open

Add experiment for enabling frames and screenshots #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32d58e2
Remove RN exclusion for frames and screenshots
sbuggay Oct 22, 2025
689b29f
Remove import
sbuggay Oct 22, 2025
83c5d8f
Remove isReactNative
sbuggay Oct 22, 2025
93152ea
Place frames under experiment
sbuggay Nov 3, 2025
977d403
Cleanup experiment
sbuggay Nov 3, 2025
ba292d9
Use correct experiment
sbuggay Nov 3, 2025
e4887b2
Merge branch 'main' into users/devanb/frames
sbuggay Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions front_end/core/rn_experiments/experimentsImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,10 @@ Instance.register({
unstable: true,
enabledByDefault: () => false,
});

Instance.register({
name: RNExperimentName.ENABLE_TIMELINE_FRAMES,
title: 'Enable performance frames track',
unstable: true,
enabledByDefault: () => globalThis.enableTimelineFrames ?? false,
});
2 changes: 2 additions & 0 deletions front_end/core/root/Runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ export enum RNExperimentName {
REACT_NATIVE_SPECIFIC_UI = 'react-native-specific-ui',
JS_HEAP_PROFILER_ENABLE = 'js-heap-profiler-enable',
ENABLE_NETWORK_PANEL = 'enable-network-panel',
ENABLE_TIMELINE_FRAMES = 'enable-timeline-frames',
}

export enum ConditionName {
Expand Down Expand Up @@ -341,6 +342,7 @@ export const enum ExperimentName {
REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
NOT_REACT_NATIVE_SPECIFIC_UI = '!' + RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
ENABLE_NETWORK_PANEL = RNExperimentName.ENABLE_NETWORK_PANEL,
ENABLE_TIMELINE_FRAMES = RNExperimentName.ENABLE_TIMELINE_FRAMES,
}

export enum GenAiEnterprisePolicyValue {
Expand Down
2 changes: 2 additions & 0 deletions front_end/global_typings/react_native.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ declare global {
// eslint-disable-next-line no-var
var enableDisplayingFullDisconnectedReason: boolean|undefined;
// eslint-disable-next-line no-var
var enableTimelineFrames: boolean|undefined;
// eslint-disable-next-line no-var
var reactNativeOpenInEditorButtonImage: string|undefined;
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
var FB_ONLY__reactNativeFeedbackLink: string|undefined;
Expand Down
9 changes: 1 addition & 8 deletions front_end/panels/timeline/TimelineFlameChartDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectWrapper<EventTypes> implements
PerfUI.FlameChart.FlameChartDataProvider {
private isReactNative = false;

private droppedFramePatternCanvas: HTMLCanvasElement;
private partialFramePatternCanvas: HTMLCanvasElement;
private timelineDataInternal: PerfUI.FlameChart.FlameChartTimelineData|null = null;
Expand Down Expand Up @@ -145,11 +143,6 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
constructor() {
super();

// [RN] Used to scope down available features for React Native targets
this.isReactNative = Root.Runtime.experiments.isEnabled(
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
);

this.reset();

this.droppedFramePatternCanvas = document.createElement('canvas');
Expand Down Expand Up @@ -615,7 +608,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
// In CPU Profiles the trace data will not have frames nor
// screenshots, so we can keep this call as it will be a no-op in
// these cases.
if (!this.isReactNative) {
if (Root.Runtime.experiments.isEnabled(Root.Runtime.RNExperimentName.ENABLE_TIMELINE_FRAMES)) {
this.#appendFramesAndScreenshotsTrack();
}

Expand Down
Loading