-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blogpost for 0.68 #3041
blogpost for 0.68 #3041
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
This version brings along a few breaking changes: | ||
|
||
- React Native has been updated to Node 16, the latest LTS. Since on CI we test for LTS and the previous LTS, this change means that users are now required to use a version of Node >= 14. | ||
- Android Gradle Plugin was updated to 7.0.1, enforcing JDK 11 for Android builds, so make sure to upgrade your configurations (we recommend you use the `temurin11` JDK flavor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially for m1 it makes sense to also mention azul as this is the only one with arm64 which cuts time for android build in half (on my machine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe temurin is also doing the same: https://github.com/Homebrew/homebrew-cask/blob/e01d3af6f8ea88ebf803ca61e85bbc42dc64aab4/Casks/temurin.rb#L2
I'm not sure the temurin11
formula has been updated to support Mac M1s, but I believe that will be updated as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cortinico The cask you linked is for temurin 17 not 11. Temurin 11 does not yet support arm64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I've followed up on the other PR. You're right here thanks for clarifying.
Side note: it should be possible to build with JDK17 (being Temurin or others) with target level 11 but it will create all sorts of problems, so better to stick to a JDK11.
|
||
- React Native has been updated to Node 16, the latest LTS. Since on CI we test for LTS and the previous LTS, this change means that users are now required to use a version of Node >= 14. | ||
- Android Gradle Plugin was updated to 7.0.1, enforcing JDK 11 for Android builds, so make sure to upgrade your configurations (we recommend you use the `temurin11` JDK flavor) | ||
- Removed `fallbackResource` from `RCTBundleURLProvider` API on iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe expand on this that its safe to just remove that parameter from the method call without any replacement.
This PR does add the 0.68 blogpost along with adding Andrei in the author.yml file :)
(as a temporary potential date I've put today, we can tweak accordingly to when it will actually happen)
It will have to be merged along with: #3033