Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blogpost for 0.68 #3041
blogpost for 0.68 #3041
Changes from 3 commits
445dd49
43139a8
6894404
b393805
a855635
9025daa
d2ff99a
c680d0d
56cf805
6f19393
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially for m1 it makes sense to also mention azul as this is the only one with arm64 which cuts time for android build in half (on my machine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe temurin is also doing the same: https://github.com/Homebrew/homebrew-cask/blob/e01d3af6f8ea88ebf803ca61e85bbc42dc64aab4/Casks/temurin.rb#L2
I'm not sure the
temurin11
formula has been updated to support Mac M1s, but I believe that will be updated as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cortinico The cask you linked is for temurin 17 not 11. Temurin 11 does not yet support arm64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I've followed up on the other PR. You're right here thanks for clarifying.
Side note: it should be possible to build with JDK17 (being Temurin or others) with target level 11 but it will create all sorts of problems, so better to stick to a JDK11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe expand on this that its safe to just remove that parameter from the method call without any replacement.