Skip to content

Commit

Permalink
Circle CI: switch to next-gen images (#33590)
Browse files Browse the repository at this point in the history
Summary:
<img width="819" alt="Screenshot 2022-04-07 at 20 42 30" src="https://user-images.githubusercontent.com/719641/162288224-1f360edd-3d9f-4f82-aac9-341d97480dfc.png">

This PR switches the Circle CI images to the next-gen ones, according to the migration guide.

With new images, specifying the minor version is required, and I have selected the latest version for each major release.

References:
* https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
* https://circleci.com/developer/images/image/cimg/node

 ---

Orbs are still using the full `circleci` name, however during the update I have spotted that used Windows Orb is quite outdated. I will push another PR and try the Orb bump in there, unless there is a reason, why the specific Orb version is used.

## Changelog

N/A

Pull Request resolved: #33590

Test Plan: Run the CI.

Reviewed By: neildhar, sshic

Differential Revision: D35550086

Pulled By: cortinico

fbshipit-source-id: b37aa9c8157b5b4f7ab3d9aac20dcb5aed028482
  • Loading branch information
Simek authored and facebook-github-bot committed Apr 11, 2022
1 parent dac56ce commit 77d2834
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ executors:
<<: *defaults
docker:
# Note: Version set separately for Windows builds, see below.
- image: circleci/node:16
- image: cimg/node:16.14
resource_class: "xlarge"
nodeprevlts:
<<: *defaults
docker:
- image: circleci/node:14
- image: cimg/node:14.19
resource_class: "xlarge"
reactnativeandroid:
<<: *defaults
Expand Down Expand Up @@ -347,7 +347,7 @@ jobs:
- run_yarn
- run:
name: Install rsync
command: sudo apt-get install rsync
command: sudo apt update && sudo apt install rsync

# -------------------------
# Run JavaScript tests
Expand Down

0 comments on commit 77d2834

Please sign in to comment.