Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI: switch to next-gen images #33590

Closed
wants to merge 2 commits into from

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Apr 7, 2022

Summary

Screenshot 2022-04-07 at 20 42 30

This PR switches the Circle CI images to the next-gen ones, according to the migration guide.

With new images, specifying the minor version is required, and I have selected the latest version for each major release.

References:


Orbs are still using the full circleci name, however during the update I have spotted that used Windows Orb is quite outdated. I will push another PR and try the Orb bump in there, unless there is a reason, why the specific Orb version is used.

Changelog

N/A

Test Plan

Run the CI.

@Simek Simek requested a review from hramos as a code owner April 7, 2022 20:24
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 7, 2022
@pull-bot
Copy link

pull-bot commented Apr 7, 2022

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 120463d

@analysis-bot
Copy link

analysis-bot commented Apr 7, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3693928
Branch: main

@analysis-bot
Copy link

analysis-bot commented Apr 7, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,766,083 -2,002
android hermes armeabi-v7a 7,169,915 -2,102
android hermes x86 8,072,330 -1,993
android hermes x86_64 8,052,453 -2,187
android jsc arm64-v8a 9,643,311 -1,968
android jsc armeabi-v7a 8,417,580 -2,064
android jsc x86 9,592,546 -1,948
android jsc x86_64 10,189,760 -2,161

Base commit: 3693928
Branch: main

@cortinico
Copy link
Contributor

cortinico commented Apr 7, 2022

Seems like the affected jobs are now failing to install rsync. Could you try to:

      - run:
          name: Install rsync
+         command: sudo apt update && sudo apt install rsync
-         command: sudo apt-get install rsync

in the circleci file?

@Simek
Copy link
Collaborator Author

Simek commented Apr 8, 2022

Adding apt update has fixed the issue thank you for the hint! 🙏

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in 77d2834.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 11, 2022
@Simek Simek deleted the circleci-switch-to-next-gen-images branch April 11, 2022 16:49
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
<img width="819" alt="Screenshot 2022-04-07 at 20 42 30" src="https://user-images.githubusercontent.com/719641/162288224-1f360edd-3d9f-4f82-aac9-341d97480dfc.png">

This PR switches the Circle CI images to the next-gen ones, according to the migration guide.

With new images, specifying the minor version is required, and I have selected the latest version for each major release.

References:
* https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
* https://circleci.com/developer/images/image/cimg/node

 ---

Orbs are still using the full `circleci` name, however during the update I have spotted that used Windows Orb is quite outdated. I will push another PR and try the Orb bump in there, unless there is a reason, why the specific Orb version is used.

## Changelog

N/A

Pull Request resolved: facebook#33590

Test Plan: Run the CI.

Reviewed By: neildhar, sshic

Differential Revision: D35550086

Pulled By: cortinico

fbshipit-source-id: b37aa9c8157b5b4f7ab3d9aac20dcb5aed028482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants