-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle CI: switch to next-gen images #33590
Conversation
|
Base commit: 3693928 |
Base commit: 3693928 |
Seems like the affected jobs are now failing to install rsync. Could you try to: - run:
name: Install rsync
+ command: sudo apt update && sudo apt install rsync
- command: sudo apt-get install rsync in the circleci file? |
Adding |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @Simek in 77d2834. When will my fix make it into a release? | Upcoming Releases |
Summary: <img width="819" alt="Screenshot 2022-04-07 at 20 42 30" src="https://user-images.githubusercontent.com/719641/162288224-1f360edd-3d9f-4f82-aac9-341d97480dfc.png"> This PR switches the Circle CI images to the next-gen ones, according to the migration guide. With new images, specifying the minor version is required, and I have selected the latest version for each major release. References: * https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034 * https://circleci.com/developer/images/image/cimg/node --- Orbs are still using the full `circleci` name, however during the update I have spotted that used Windows Orb is quite outdated. I will push another PR and try the Orb bump in there, unless there is a reason, why the specific Orb version is used. ## Changelog N/A Pull Request resolved: facebook#33590 Test Plan: Run the CI. Reviewed By: neildhar, sshic Differential Revision: D35550086 Pulled By: cortinico fbshipit-source-id: b37aa9c8157b5b4f7ab3d9aac20dcb5aed028482
Summary
This PR switches the Circle CI images to the next-gen ones, according to the migration guide.
With new images, specifying the minor version is required, and I have selected the latest version for each major release.
References:
Orbs are still using the full
circleci
name, however during the update I have spotted that used Windows Orb is quite outdated. I will push another PR and try the Orb bump in there, unless there is a reason, why the specific Orb version is used.Changelog
N/A
Test Plan
Run the CI.