Skip to content

Commit

Permalink
Restore envinfo for test_windows (#38062)
Browse files Browse the repository at this point in the history
Summary:
We had to disable the envinfo command on test_windows to get the CI back to green.

The reason why it started failing is because they released 7.9.0 which does not seem to have the executable on Windows, so `npx` fails to find what to run.

This fix restore the command in a way that it should display the envinfo using an older version of the package. I also added a task to come back to this periodically.

## Changelog:

[Internal] - Restore envinfo on windows

Pull Request resolved: #38062

Test Plan: - CircleCI: test_windows stays green

Reviewed By: cortinico

Differential Revision: D47016995

Pulled By: cipolleschi

fbshipit-source-id: 368367caed7ea49d7419475580a39f9406c54757
  • Loading branch information
Riccardo Cipolleschi authored and facebook-github-bot committed Jun 26, 2023
1 parent 772c9eb commit eaafc26
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1067,9 +1067,15 @@ jobs:
name: Enable Yarn with corepack
command: corepack enable

# - run:
# name: Display Environment info
# command: npx envinfo@latest
# it looks like that, last week, envinfo released version 7.9.0 which does not works
# with Windows. I have opened an issue here: https://github.com/tabrindle/envinfo/issues/238
# TODO: T156811874 - Revert this to npx envinfo@latest when the issue is addressed
- run:
name: Display Environment info
command: |
npm install -g envinfo
envinfo -v
envinfo
- restore_cache:
keys:
Expand Down

0 comments on commit eaafc26

Please sign in to comment.