[RN][Windows] Restore envinfo for test_windows #38062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by Riccardo Cipolleschi in eaafc26. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
Summary: We had to disable the envinfo command on test_windows to get the CI back to green. The reason why it started failing is because they released 7.9.0 which does not seem to have the executable on Windows, so `npx` fails to find what to run. This fix restore the command in a way that it should display the envinfo using an older version of the package. I also added a task to come back to this periodically. ## Changelog: [Internal] - Restore envinfo on windows Pull Request resolved: #38062 Test Plan: - CircleCI: test_windows stays green Reviewed By: cortinico Differential Revision: D47016995 Pulled By: cipolleschi fbshipit-source-id: 368367caed7ea49d7419475580a39f9406c54757 # Conflicts: # .circleci/config.yml
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We had to disable the envinfo command on test_windows to get the CI back to green.
The reason why it started failing is because they released 7.9.0 which does not seem to have the executable on Windows, so
npxfails to find what to run.This fix restore the command in a way that it should display the envinfo using an older version of the package. I also added a task to come back to this periodically.
Changelog:
[Internal] - Restore envinfo on windows
Test Plan: