Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native install to use Yarn #11122

Closed
theobouwman opened this issue Nov 24, 2016 · 5 comments
Closed

react-native install to use Yarn #11122

theobouwman opened this issue Nov 24, 2016 · 5 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@theobouwman
Copy link

react-native install does not use Yarn if available
@mkonicek
Copy link
Contributor

Hey, thanks for reporting this issue!

It's only supported in react-native init: http://facebook.github.io/react-native/blog/2016/11/08/introducing-button-yarn-and-a-public-roadmap.html

Good point, need to support it also in react-native install. Thanks!

@mkonicek mkonicek assigned mkonicek and unassigned mkonicek Nov 24, 2016
@mkonicek mkonicek added the Help Wanted :octocat: Issues ideal for external contributors. label Nov 24, 2016
@mkonicek
Copy link
Contributor

PRs welcome! :)

@saigrandhi
Copy link
Contributor

I would like to work on this issue. Which files should I look at to solve it?

@leeight
Copy link
Contributor

leeight commented Nov 25, 2016

@saigrandhi local-cli/install

@olingern olingern mentioned this issue Dec 3, 2016
Closed
@olingern
Copy link

olingern commented Dec 3, 2016 •
edited
Loading

I hope it's okay I've taken a stab at this. I help a little bit with Yarn, so I'd love to see it grow.

A bit green to the project, and I didn't see an obvious way to invoke the local-cli/install command (a bin folder, for example). Could you point me toward testing this out?

I've opened a "rough draft" of a PR #11280.

@n3tr is on this one at #11174

@n3tr n3tr mentioned this issue Dec 3, 2016
Closed
edmofro pushed a commit to edmofro/react-native that referenced this issue Feb 6, 2017
@n3tr
Use Yarn for Install/Uninstall CLI if available
d1ba125 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 7, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
7605706 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
normanjoyner pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @normanjoyner
Use Yarn for Install/Uninstall CLI if available
7c79c1d 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
3a93839 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
dbec83a 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
ff87b14 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
5badff3 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
180beb0 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
633aeb3 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
9724a7c 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
1aca6d3 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
8ec9635 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@n3tr @nicktate
Use Yarn for Install/Uninstall CLI if available
fbcd525 
Summary:
Make `react-native install` and `uninstall` cli to use yarn if available (fixes facebook#11122)

**Test plan Yarn**

1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeApp
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**Test plan NPM**
1. Publish to Sinopia: https://github.com/facebook/react-native/tree/master/react-native-cli
2. react-native init AwesomeAppNPM --npm
3. react-native install react-native-fit-image
4. react-native uninstall react-native-fit-image

**output (yarn.lock)**

```
> react-native install react-native-fit-image
yarn add v0.16.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency
└─ react-native-fit-image@1.4.6
✨  Done in 4.11s.
rnpm-install info Module react-native-fit-image has been successfully
Closes facebook#11174

Differential Revision: D4441872

fbshipit-source-id: 05bd30e1ad14bdbe861259c88e1f18df77cfa54f
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Yarn for Install/Uninstall CLI if available n3tr/react-native
6 participants
@leeight @mkonicek @olingern @theobouwman @saigrandhi @react-native-bot