Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add yarn support for package install #11280

Closed
wants to merge 1 commit into from
Closed

WIP: add yarn support for package install #11280

wants to merge 1 commit into from

Conversation

olingern
Copy link

@olingern olingern commented Dec 3, 2016

Explain the motivation for making this change. What existing problem does the pull request solve?
Fixes #11122

Test plan (required)

  • Init / Install without Yarn installed on system (force npm). Ensure install does not mix Yarn / npm if Yarn is available after installing with npm.
  • Init / Install with Yarn installed on system. Ensure install continues to only use yarn.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @grabbou to be a potential reviewer.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2016
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@n3tr
Copy link
Contributor

n3tr commented Dec 3, 2016

Hi @olingern, I'm working on adding Yarn support for cli as well. please check it out #11174 :)

@olingern
Copy link
Author

olingern commented Dec 4, 2016

@n3tr Awesome! Sorry, I didn't see anything in #11122 mentioning you were on it. All yours :)

@olingern olingern closed this Dec 4, 2016
@n3tr
Copy link
Contributor

n3tr commented Dec 4, 2016

@olingern sorry, it was my mistake 😢. I haven't carefully checked for the issue and just realized when you mentioned to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants