Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListHeaderComponent should not be considered the top of a list view #17743

Closed
Dexwell opened this issue Jan 25, 2018 · 3 comments
Closed

ListHeaderComponent should not be considered the top of a list view #17743

Dexwell opened this issue Jan 25, 2018 · 3 comments
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@Dexwell
Copy link

Dexwell commented Jan 25, 2018

Is this a bug report?

Depends on whether this is intended behavior.

Have you read the Contributing Guidelines?

Yes.

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 9.4.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.52.0 => 0.52.0

Target Platform: iOS (11.2)

Steps to Reproduce

  1. Create a SectionList
  2. Add a ListHeaderComponent to the SectionList

Expected Behavior

The ListHeaderComponent would initially be hidden, and would only be revealed by scrolling up, similar to a search or filter bar on iOS. Scrolling to the top of the list (for example by tapping the status bar) would scroll to the top of the first item in the list, not to the top of the header component.

Actual Behavior

The ListHeaderComponent is rendered as if it were the first item in the list, and tapping the status bar scrolls to the top of the header component. I assume this is not the intended behavior, since the same can be achieved by using a different section on top of the list view with its own renderItem function. If the ListHeaderComponent is implemented the way I expected, it would make it much easier to implement custom search bars, filter bars, and the like.

Reproducible Demo

https://snack.expo.io/BJDvzFwBz

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@Dexwell
Copy link
Author

Dexwell commented Feb 25, 2018

Still a thing in v0.53.0. New issue: #18083

@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants