-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdSupportIOS] better module exports for AdSupportIOS #666
Conversation
better var { AdSupportIOS, } = React;
I think the code for this looks good but @lvyile you should probably squash your commits. Someone from Facebook or more of a decision maker on the project probably needs to say whether var AdSupportIOS = require('AdSupportIOS'); or var React = require('react-native');
var {
//...
AdSupportIOS,
//...
} = React; is preferred. @brentvatne ? |
I think the latter example is preferred in this case @ccheever. One thing that we will want to do in addition to this is add some documentation in Agreed re:squashing, can you squash your commits into one @lvyile? |
Seems like this now works as intended. |
@lvyile updated the pull request. |
* Bump bs-platform to 7.2.0 * Record as objects * Update src/apis/NetInfo.md Co-Authored-By: Max Thirouin <git@moox.io> * Update src/apis/CameraRoll.re Co-Authored-By: Max Thirouin <git@moox.io> * Update documentation file VirtualizedSectionList * Update documentation files * Add missing bs.meth decorator * Documentation fixes * Documentation fixes * Documentation updates Co-authored-by: Max Thirouin <git@moox.io>
* change back to localhost * boost path gradlew change * whitespace
Before:
After: