Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The --device option fails on command line in v53.0 #17973

Closed
gulci opened this issue Feb 14, 2018 · 9 comments
Closed

The --device option fails on command line in v53.0 #17973

gulci opened this issue Feb 14, 2018 · 9 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@gulci
Copy link

gulci commented Feb 14, 2018 •
edited
Loading

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.1
Yarn: Not Found
npm: 5.5.1
Watchman: Not Found
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.0 => 0.53.0

Steps to Reproduce

  1. Initiate a new React Native project using react-native init projectName
  2. Run the command react-native run-ios --device deviceName

Expected Behavior

The app should have launched on my physical device. Additionally, if I already have an instance of Metro Bundler running using react-native start, it should just hook into that one and use that.

Actual Behavior

Metro Bundler opens and complains that Metro Bundler can't listen on port undefined. It then prompts the user to hit enter because the process has terminated. I've run into other random errors too. I've included one of those here as well.

Metro Bundler error 1
Metro Bundler error 2

Additionally, there is a lot of output in my main terminal about the Xcode build failing. I can include the full output in a comment below if requested.

Build error 1
Build error 2

Even if I try running an instance of Metro Bundler using react-native start before running react-native run-ios --device deviceName, it just starts a new instance in a new terminal window.

Reproducible Demo

You can reproduce this with a brand new project created using react-native init projectName.
@gulci gulci mentioned this issue Feb 14, 2018
Closed
jozan added a commit to jozan/react-native that referenced this issue Feb 14, 2018
@jozan
Pass port when running on device (fix facebook#17973)
c8bb67e
@jozan jozan mentioned this issue Feb 14, 2018
Closed
Plo4ox pushed a commit to Plo4ox/react-native that referenced this issue Feb 17, 2018
@jozan
Pass port when running on device (fix facebook#17973)
335a0cd 
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

Building for iOS device `react-native run-ios --device [id]` fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.

I've tested this in our app and also in fresh app using RN master and verified that it works.

None.

[CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device
<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#17983

Differential Revision: D6988299

Pulled By: hramos

fbshipit-source-id: 5169706600f87f13b9c9c105eb7d6db7a40194f1
grabbou pushed a commit that referenced this issue Feb 20, 2018
@jozan @grabbou
Pass port when running on device (fix #17973)
ee60c11 
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

Building for iOS device `react-native run-ios --device [id]` fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.

I've tested this in our app and also in fresh app using RN master and verified that it works.

None.

[CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device
<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes #17983

Differential Revision: D6988299

Pulled By: hramos

fbshipit-source-id: 5169706600f87f13b9c9c105eb7d6db7a40194f1
@nuke99
Copy link

nuke99 commented Feb 22, 2018

I have the same issue

@johanleroch
Copy link

Same issue too

@gulci
Copy link
Author

gulci commented Mar 2, 2018 •
edited
Loading

@nuke99 , @johanleroch

This has already been fixed for me. Update to the latest react-native.

@mlazari
Copy link
Contributor

mlazari commented Mar 3, 2018 •
edited
Loading

@gulci Which version fixed the error? I have the same error with "react-native": "0.54.0". Running from Xcode works fine. The error appears only when I'm trying to run from the terminal with react-native run-ios --device="Mihai"

P.S. I found the fix #17983
It is included in 0.53.3, but not in 0.54.0

@gulci
Copy link
Author

gulci commented Mar 3, 2018

@mlazari

Lol wow. Want me to open a new issue? Yeah I was on 0.53.3.

@johanleroch
Copy link

@gulci

Haha if you want yes :)
I have the same problem on the 0.54.0

@gulci
Copy link
Author

gulci commented Mar 3, 2018

I'll open the exact same issue. ;)

@gulci gulci mentioned this issue Mar 3, 2018
Closed
xiamx pushed a commit to xiamx/react-native that referenced this issue Mar 13, 2018
@jozan @xiamx
Pass port when running on device (fix facebook#17973)
176b887 
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

Building for iOS device `react-native run-ios --device [id]` fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.

I've tested this in our app and also in fresh app using RN master and verified that it works.

None.

[CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device
<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#17983

Differential Revision: D6988299

Pulled By: hramos

fbshipit-source-id: 5169706600f87f13b9c9c105eb7d6db7a40194f1
@tintorres
Copy link

I have the same issue v0.55.0-rc . I'm on
macOS High Sierra 10.13.3
yarn 1.3.2

Problem does not exists on v0.52
So I'm guessing this issue introduced in v0.53

@grabbou
Copy link
Contributor

grabbou commented Mar 24, 2018

@tintorres the fix for this issue is on 0.55-stable branch so technically, there should be no errors on latest RC. Please double check.

To everyone else in this thread, this has been fixed in 0.55.0-rc.0 and will soon be available in the stable channel.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 14, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@nuke99 @grabbou @mlazari @johanleroch @gulci @tintorres @react-native-bot