Pass port when running on device (fix #17973)

[jozan]

Motivation

Building for iOS device react-native run-ios --device [id] fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.

Test Plan

I've tested this in our app and also in fresh app using RN master and verified that it works.

Related PRs

None.

Related Issues

#17973: The --device option fails on command line in v53.0

Release Notes

[CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device

[chirag04]

@facebook-github-bot shipit

[facebook-github-bot]

Something went wrong executing that command, @hramos could you take a look?

[facebook-github-bot]

@chirag04 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[jozan]

Thanks for merging. :)

…

On Wed, 14 Feb 2018 at 18.20, Facebook Community Bot < ***@***.***> wrote: Closed #17983 <#17983> via f8fee0a <f8fee0a> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17983 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqYQmeS1s-vVsXSgypaAE51X3yFDQks5tUwfUgaJpZM4SFfiP> .

[MrLoh]

Any way to use react native 53 on device? Is this already available as some beta that can be installed?

[jozan]

@MrLoh This is merged to master for now. It might be considered worth a hassle to release patch. I have no idea how all this works so I suggest you to follow this thread and watch for new releases: #17520

[MrLoh]

Well for now I fixed it by adding the args.port manually in my node_modules/react-native/local-cli/runIOS/runIOS.js it's on line 61 in the 0.53 release (there were other changes that added ten lines before your release). It's a bit scary that stuff like that doesn't get checked before a release.

I'm very glad about the --port option though.

[hramos]

You can build from source if you want to take advantage of the fix before it makes it into a release.

[agates4]

Is there an ETA for release?

[MrLoh]

Probably the next release beginning of March. Just fix it locally until then

_{Sent with GitHawk}

[agates4]

For anyone else looking for a quick fix -

in node_modules/react-native/local-cli/runIOS/runIOS.js

change runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration, args.packager, args.verbose);

to runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration, args.packager, args.verbose, args.port);

[mlazari]

Why is this fix included in v0.53.3, but not in v0.54.0?

[hramos]

The fix, f8fee0a, is only on master. You should expect this fix to be part of the 0.55 release, known as March 2018. It should enter RC status this week, and be available as a stable release next month.

[jozan]

Thanks for your response hramos :) I’m quite surprised the way this fix was not included to 0.54. Looking forward to 0.55 RC. Is there any writeup where RN release process is described? It might clarify things like which commits make to release and which will not.

…

On Mon, 5 Mar 2018 at 21.44, Héctor Ramos ***@***.***> wrote: The fix, f8fee0a <f8fee0a>, is only on master. You should expect this fix to be part of the 0.55 release, known as March 2018. It should enter RC status this week, and be available as a stable release next month. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17983 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqeMx_82wJcMYBwXauhH2og2KRI0Dks5tbZVwgaJpZM4SFfiP> .

[hramos]

Yup, this is all documented in the versions page: http://facebook.github.io/react-native/versions.html

We follow a monthly release train. Once a commit lands on master, it will make it into the next release candidate. As this commit landed after 0.54-RC was created, it has to wait for the 0.55-RC. We follow this process to ensure all changes soak for a month in order to surface any urgent issues. On rare occasion, we might cherry pick a fix into a particular RC, but the bar for doing so is quite high (i.e. it is a regression or it breaks all apps). Generally, feature fixes like this one are not good candidates for cherry-picking. Thanks for your patience.

[jozan]

Thanks you for explanation! Also, nice work all around in issues and PRs hramos. :)

…

On Tue, 6 Mar 2018 at 0.36, Héctor Ramos ***@***.***> wrote: Yup, this is all documented in the versions page: http://facebook.github.io/react-native/versions.html We follow a monthly release train. Once a commit lands on master, it will make it into the next release candidate. As this commit landed after 0.54-RC was created, it has to wait for the 0.55-RC. We follow this process to ensure all changes soak for a month in order to surface any urgent issues. On rare occasion, we might cherry pick a fix into a particular RC, but the bar for doing so is quite high (i.e. it is a regression or it breaks all apps). Generally, feature fixes like this one are not good candidates for cherry-picking. Thanks for your patience. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17983 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqUKrHOx0LKTKO5DPGme7uW3O_n4pks5tbb3HgaJpZM4SFfiP> .