-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Compile fails when gflags is installed #28446
Comments
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
Still in the Backlog |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
I'd assume it's still an issue |
I am also facing this issue it is due to wrong glog which is installed using brew. But why i have to remove all the glog in mac os. |
Following steps worked for me
|
Yes uninstalling it "fixes" it. |
Summary: Fixes the issue explained in #28446 It basically disabled the gflags include before configure can detect the header on the users system. ## Changelog [iOS] [Fixed] - Fixed inability to build apps when gflags is installed Pull Request resolved: #28451 Test Plan: Tested by installing gflags `brew install gflags` and verifying that apps build after. Reviewed By: javache Differential Revision: D30345352 Pulled By: sota000 fbshipit-source-id: 04c98d7ddebe6708057407c4b4bf3701434822a3
I'm receiving the following error for
Following the comments above, I removed |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
When trying to build an iOS version of a react native app, the compilation of the
glog
(andFlipp-er-Glog
) pods will fail if the machine has the gflags package installed (brew install gflags
).This seems to be due to the configure script picking up the
gflags.h
file and in turn enabling this line in logging.h by setting the if precompile flag to true:React Native version:
This bug should hit all existing RN versions that relay on glog and starting RN 62 also the Flipper integration.
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
brew install gflags
gflags
Expected Results
The app should still compile regardless if the user has setup gflags or not.
Snack, code example, screenshot, or link to a repository:
Not needed
The text was updated successfully, but these errors were encountered: