[Android] Inverted FlatList + Text Input causing ANR on android 13

[hannojg]

Description

When having a FlatList and a TextInput in one view and the FlatList has the inverted={true} prop set and the android device is on API 33 (Android 13) the app will freeze/die in an ANR.

Screen.Recording.2022-11-15.at.12.52.22.mov

Version

0.70.5

Output of npx react-native info

info Fetching system and libraries information...
System:
    OS: macOS 12.6
    CPU: (8) arm64 Apple M1 Pro
    Memory: 96.63 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK:
      API Levels: 28, 29, 30, 31, 32, 33
      Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0, 33.0.0
      System Images: android-32 | Google APIs ARM 64 v8a, android-32 | Google APIs Intel x86 Atom_64, android-32 | Google Play ARM 64 v8a, android-33 | Google APIs ARM 64 v8a, android-33 | Google Play ARM 64 v8a
      Android NDK: 21.4.7075529
  IDEs:
    Android Studio: Chipmunk 2021.2.1 Patch 1 Chipmunk 2021.2.1 Patch 1
    Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
  Languages:
    Java: 17.0.5 - /Users/hannogodecke/.jenv/shims/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0 
    react-native: 0.70.5 => 0.70.5 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

• Clone this repository
• Run yarn
• Run yarn start
• Run yarn android, make sure the app launches on a device with android API 33 (Android 13)
• Open the app
• Open the developer tools and enable the performance monitor
• Focus the text input
• Run the following in your terminal:

adb shell input text "Lorem\ ipsum\ dolor\ sit\ amet,\ consetetur\ sadipscing\ elitr,\ sed\ diam\ nonumy\ eirmod\ tempor\ invidunt\ ut\ labore\ et\ dolore\ magna\ aliquyam\ erat,\ sed\ diam\ voluptua.\ At\ vero\ eos\ et\ accusam\ et\ justo\ duo\ dolores\ et\ ea\ rebum.\ Stet\ clita\ kasd\ gubergren,\ no\ sea\ takimata\ sanctus\ est\ Lorem\ ipsum\ dolor\ sit\ amet.\ Lorem\ ipsum\ dolor\ sit\ amet,\ consetetur\ sadipscing\ elitr,\ sed\ diam\ nonumy\ eirmod\ tempor\ invidunt\ ut\ labore\ et\ dolore\ magna\ aliquyam\ erat,\ sed\ diam\ voluptua.\ At\ vero\ eos\ et\ accusam\ et\ justo\ duo\ dolores\ et\ ea\ rebum.\ Stet\ clita\ kasd\ gubergren,\ no\ sea\ takimata\ sanctus\ est\ Lorem\ ipsum\ dolor\ sit\ amet."

• Run it repeatedly until the app freezes (for me it takes ~ 3 repetitions until the ANR happens. On a real Pixel 4 of a colleague the app almost freezes immediately).

Snack, code example, screenshot, or link to a repository

https://github.com/hannojg/RN-AndroidAPI33-TextInput-ANR

[rudenick0309]

#35155
The similar problem seems to occur even with only 'TextInput'

[hannojg]

Interestingly the TextInput works for me on the device but stops working once it's next to an inverted FlatList. So I am not entirely sure if it's related, but I will test the reproduction of the issue you mentioned as well!

[hannojg]

Observations I made:

• I just put a plain android EditText view instead of RN's TextInput and the issue still happens (so I assume it isn't the TextInput implementation)
• I tried it with VirtualizedList and the following styles (to re-create the inverted effect), but the ANR still happens:

style={{
    transform: [{scaleY: -1}],
}}
contentContainerStyle={{
    transform: [{scaleY: -1}],
}}

• I tried it with ScrollView (used by VirtualizedList) using the styles above, and the issue keeps happening as well
• If I don't do the inverted styling (its the same way VirtualizedList does it) the ANR doesn't happen

Still looking for the place that's causing the issue 🔍

[JuanAlejandro]

@hannojg we had the same problem with our app. We are using the inverted FlatList in our chat screen. One time I wasn't typing, I was just receiving messages and the app froze. So I'm not 100% sure the TextInput is needed to repro. The workaround we implemented was to invert the list with styles instead of the prop. You can check the solution in this Github issue.

Ah! And also this issue was happening only for Pixel devices with Android 13. Since the first family of devices to get Android 13 was the Pixel, maybe that's why we only saw this issue in Pixel devices.

[hannojg]

Wow thx for sharing this information, will give it a try!

What I found is, that you don't even need a list. You just need two views that have scaleY: 1 set:

     <View
        style={{
          flex: 1,
          backgroundColor: 'red',
          transform: [{scaleY: -1}],
        }}>
        <View
          style={{
            transform: [{scaleY: -1}],
          }}>
           {/* Some more children inside here that got inverted */}

However, I still need to input text constantly into a TextInput to cause the ANR 😅

[hannojg]

Okay, the issue doesn't happen anymore if I also add scaleX: -1 👀 :

     <View
        style={{
          flex: 1,
          backgroundColor: 'red',
          transform: [{scaleX: -1}, {scaleY: -1}],
        }}>
        <View
          style={{
            transform: [{scaleX: -1}, {scaleY: -1}],
          }}>

Going to dig into the native code to see where the issue happens, maybe also a bug with yoga?

[rudenick0309]

@hannojg @JuanAlejandro sorry for telling this, this problem was occured at real device of galaxy22 with google play system version - 22.07.01, but, after updating google play system version to '22.10.01'. the problem was disappeared. ( i could not test my local, that device is our customer. )
so, i am looking for other galaxy22 for verifying. after results are out, i will write down.

[hannojg]

I just found the offending line that's causing the issue. If I remove the view.setRotationX line the issue stops happening.
At this point I am not sure whether this is a react native or an android bug. Will dig deeper:

react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

Lines 441 to 483 in e504141

	private static void setTransformProperty(@NonNull View view, ReadableArray transforms) {
	sMatrixDecompositionContext.reset();
	TransformHelper.processTransform(transforms, sTransformDecompositionArray);
	MatrixMathHelper.decomposeMatrix(sTransformDecompositionArray, sMatrixDecompositionContext);
	view.setTranslationX(
	PixelUtil.toPixelFromDIP(
	sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.translation[0])));
	view.setTranslationY(
	PixelUtil.toPixelFromDIP(
	sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.translation[1])));
	view.setRotation(
	sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.rotationDegrees[2]));
	view.setRotationX(
	sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.rotationDegrees[0]));
	view.setRotationY(
	sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.rotationDegrees[1]));
	view.setScaleX(sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.scale[0]));
	view.setScaleY(sanitizeFloatPropertyValue((float) sMatrixDecompositionContext.scale[1]));
	double[] perspectiveArray = sMatrixDecompositionContext.perspective;
	if (perspectiveArray.length > PERSPECTIVE_ARRAY_INVERTED_CAMERA_DISTANCE_INDEX) {
	float invertedCameraDistance =
	(float) perspectiveArray[PERSPECTIVE_ARRAY_INVERTED_CAMERA_DISTANCE_INDEX];
	if (invertedCameraDistance == 0) {
	// Default camera distance, before scale multiplier (1280)
	invertedCameraDistance = 0.00078125f;
	}
	float cameraDistance = -1 / invertedCameraDistance;
	float scale = DisplayMetricsHolder.getScreenDisplayMetrics().density;
	// The following converts the matrix's perspective to a camera distance
	// such that the camera perspective looks the same on Android and iOS.
	// The native Android implementation removed the screen density from the
	// calculation, so squaring and a normalization value of
	// sqrt(5) produces an exact replica with iOS.
	// For more information, see https://github.com/facebook/react-native/pull/18302
	float normalizedCameraDistance =
	sanitizeFloatPropertyValue(
	scale * scale * cameraDistance * CAMERA_DISTANCE_NORMALIZATION_MULTIPLIER);
	view.setCameraDistance(normalizedCameraDistance);
	}
	}

[hannojg]

So at this point, I was able to reproduce the issue with just a native android project (no react native involved). It's a bug in the android framework.

I tried to create an issue ticket on the AOSP, however, after creation, I get weird permission errors and the bug ticket just disappears.

Sorry for the ping, but maybe @cortinico you can help with opening a bug ticket for the android team (I recall you were an android engineer? 😅 )?

The bug report for the native android looks like this:

Setting scaleY: -1 and rotationX: 180 for two nested views causes an ANR on android API 33

On Android 13 we are noticing an ANR, when we have two views that have each:

scaleY: -1

rotationX: 180

set.

In the video, you can see a green view, the parent of a blue view (and the blue view has a lot of children (list)). Both views have the transformation properties set (creating an "inverted" effect).

We then have an EditText rendered underneath these views. When entering text the ANR happens. This is much easier to reproduce on a real device. We are reproducing with a Pixel 4 Android API 33 emulator. Here you need to enter text rapidly with the help of add shell input text to cause the ANR.

In the bottom right you can see a small FPS counter (using Choreographer), and you can see that the app starts to freeze at some point.

The full reproduction: https://github.com/hannojg/AndroidScaleYReproductionANR-

I also attached an adb bugreport (it's from an emulator, so no sensitive data)

The important code part to reproduce:

class MainActivity : AppCompatActivity() {
    private lateinit var binding: ActivityMainBinding

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        binding = ActivityMainBinding.inflate(layoutInflater)
        setContentView(binding.root)

        val parentView = RelativeLayout(this)
        parentView.layoutParams = ViewGroup.LayoutParams(1000, 2000)
        parentView.setBackgroundColor(0xFF00FF00.toInt())
        parentView.scaleY = -1f
        parentView.rotationX = 180f

        // add a child view to the parentView which we invert as well:
        val childView = LinearLayout(this)
        childView.orientation = LinearLayout.VERTICAL
        childView.layoutParams = ViewGroup.LayoutParams(800, 1800)
        childView.setBackgroundColor(0xFF0000FF.toInt())
        childView.scaleY = -1f
        childView.rotationX = 180f

        parentView.addView(childView)

        // add 20 text views to the child view
        for (i in 0..19) {
            val textView = TextView(this)
            val layoutPrams = ViewGroup.MarginLayoutParams(200, 100)
            layoutPrams.topMargin = 10
            textView.layoutParams = layoutPrams
            textView.setBackgroundColor(0xFFD3D3D3.toInt())
            textView.gravity = Gravity.CENTER
            textView.text = "Text $i"

            childView.addView(textView)
        }

        binding.rootLayout.addView(parentView)
    }
}

Thanks in advance for checking!

android-reproduction.mov

[cortinico]

Sorry for the ping, but maybe @cortinico you can help with opening a bug ticket for the android team (I recall you were an android engineer? 😅 )?

You can do so by yourself here:
https://issuetracker.google.com/issues

[cortinico]

Closign also as it's a Android Bug apparently. Feel free to reopen if they send you here

[GuoXiaoyang]

@hannojg Hi, have you opened a bug ticket for the android team? Same issue here.

[hannojg]

Yeah that's the point, opening a bug ticket at https://issuetracker.google.com/issues doesn't work for me and results in permission errors.
Does anyone of you have created an issue there and can help with that?

[GuoXiaoyang]

Yeah that's the point, opening a bug ticket at https://issuetracker.google.com/issues doesn't work for me and results in permission errors. Does anyone of you have created an issue there and can help with that?

I will have a try. And I noticed that you have forked the React Native repo and added a verticalScrollbarPosition prop to FlatList to fix this issue as a workaround. But it's a little difficult for us to use a forked RN version😭.
I will try to find another solution if possible. Do you have any suggestions?

[hannojg]

Yeah please try, you can copy paste the bug report I pasted in one of the above comments.
I always get this weird error after creation:

Yeah, I was thinking about adding verticalScrollbarPosition prop to react native itself. Unfortunately, I haven't found any other workaround yet

[EmilScherdin]

@hannojg I believe I succeeded to add it with the correct info and at the right place (the issue tracker is a jungle 😅) https://issuetracker.google.com/issues/261572772

[hannojg]

@EmilScherdin unfortunately not, I can't open that issue either:

[MohammadAzimi]

The issue is closed. Then what is the workaround or any update in react native? Can someone help me please

[stelmakhivan]

@hannojg is this issue already fixed in react-native v0.72.4?
https://github.com/facebook/react-native/releases/tag/v0.72.4

[winterdouglas]

The android bug tracker seems to be working again: https://issuetracker.google.com/issues/287304310

Meanwhile I am preparing a workaround fix for within react native.

Any chances that your fix is also applied to 0.71? :) @hannojg

[roryabraham]

It looks like as of now it's only applied in 0.73: 3dd816c

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[phatmann]

Is this actually fixed?

[hannojg]

ah yeah it is, we applied a workaround in react native:

• 90186cd
• 6d206a3