-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to create new RN 0.72 project with Node 16 #39692
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Is it possible for your project to update node version? But if possible, probably it's cleaner to update node version |
@duasfh thanks, I'm personally not affected, this was an issue we saw on our CI, we've updated CI to node 18, so we're fine. But I don't think it was an intended/documented change that rn 0.72.* requires node 18 now. |
Considering the latest stable RN includes the following in
I would kindly ask for a RN side resolution to this. Not sure if this is an acceptable approach, but it comes to mind; publishing For the time being I'm resolving this on my side using:
In my |
Thanks for flagging this @mfazekas, we're currently investigating what's the best resolution for this problem. As you mentioned, setting the |
Closing as per #39698 |
Summary: To address the root cause of a recurring issue (#40797, #39692) where breaking changes to `react-native/normalize-colors` would be pulled into old versions of `deprecated-react-native-prop-types`, we recently change the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869). For CI, we generally force `react-native/*` to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently `0.74.1`) isn't semver-compatible with `deprecated-react-native-prop-types`'s dependency (`^0.73.0`), so `npm install` was failing in CI with "no package found". We should be getting `0.73.2` from the public registry in this case. This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more. ## Changelog: [INTERNAL] [FIXED] - CI/Verdaccio: Proxy `react-native/normalize-colors` from NPM for the `deprecated-react-native-prop-types` dependency. Pull Request resolved: #40971 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D50298291 Pulled By: robhogan fbshipit-source-id: 4bf6503108335ffa52654346d1874c217071ff91
Description
Looks like the issue was caused by recent publish of
@react-native/normalize-colors@0.73.1
https://github.com/facebook/react-native/tree/main/packages/normalize-color
React Native Version
0.72.5
Output of
npx react-native info
Steps to reproduce
Snack, screenshot, or link to a repository
See also #38298
The text was updated successfully, but these errors were encountered: