-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Verdaccio: proxy @react-native/normalize-colors
from NPM
#40971
Conversation
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 9497203 |
Then we probably don't need this rule inside Verdaccio config. Looking at https://verdaccio.org/docs/packages, can you try specifying |
This pull request was successfully merged by @robhogan in d282ebe. When will my fix make it into a release? | Upcoming Releases |
@hoxyq I believe we need the rule in order to allow the transitive dependency on One alternative would be to publish a patched version of |
I see - some CI jobs rely pulling I'm not familiar enough with Verdaccio to know if |
Summary:
To address the root cause of a recurring issue (#40797, #39692) where breaking changes to
@react-native/normalize-colors
would be pulled into old versions ofdeprecated-react-native-prop-types
, we recently changed the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869).For CI, we generally force
@react-native/*
to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently0.74.1
) isn't semver-compatible withdeprecated-react-native-prop-types
's dependency (^0.73.0
), sonpm install
was failing in CI with "no package found". We should be getting0.73.2
from the public registry in this case.This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more.
Changelog:
[INTERNAL] [FIXED] - CI/Verdaccio: Proxy
@react-native/normalize-colors
from NPM for thedeprecated-react-native-prop-types
dependency.Test Plan:
CI