add Image border*Radius tests #20264
Conversation
facebook-github-bot
added
the
CLA Signed
|
Not sure why CI is failing on iOS |
|
Awesome! Thanks for the additional tests. Since these are visual tests, can you add screenshot tests for these? I believe there are instructions in the docs somewhere for how to add these tests. Maybe in the contributing docs. |
|
@TheSavior I see snapshot tests described in RN docs here. But it's only for iOS. For Android, even though I see screenshot-tests-for-android in the wild, I do not see React Native using them (e.g. there is no mention of the screenshot-tests-for-android plugin in a build.gradle). Unfortunately, I do not have access to an iOS dev environment (I'm on Windows). So I cannot add screenshot tests to existing iOS ones. And since Android does not have snapshot testing, this would require adding this feature to the Android test suite. Do you require me to do this? |
|
@TheSavior gentle ping. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for the ping! |
|
This pull request was closed by Yury Zholobov in 9b5b07f. Once this commit is added to a release, you will see the corresponding version tag below the description at 9b5b07f. If the commit has a single |
Summary: Pull Request resolved: #20264 Differential Revision: D9228814 Pulled By: TheSavior fbshipit-source-id: cad4c15e8070c7ab2023c20045b82f7ab3f994cf
Summary: Pull Request resolved: facebook/react-native#20264 Differential Revision: D9228814 Pulled By: TheSavior fbshipit-source-id: cad4c15e8070c7ab2023c20045b82f7ab3f994cf
hramos
removed
Import Started
Test Plan:
Run RNTester and check visuals for Image borders are what is expected.
Release Notes:
[GENERAL] [MINOR] [RNTester] - Added tests for Image's border*Radius props.